bug/#628 - special "internet error" case for scan carousel product card #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el product card New file: * `smooth_product_card_error.dart`: Product Card when an exception is caught Impacted files: * `continuous_scan_model.dart`: new value `ScannedProductState.ERROR`, used when an exception is caught during API call * `smooth_product_carousel.dart`: handling the `ScannedProductState.ERROR` case
|
Can we perhaps add something like "Impossible to fetch information about this product due to a network error." |
|
@teolemon That would look like that: In addition to that, I had problems with the scan, and decided to type in the barcode. |
… over internet errors New file: * `fetched_product.dart`: combo of Product and its fetch status Impacted files: * `app_en.arb`: added translations for "internet error" and "canceled by user" * `barcode_product_query.dart`: now using `FetchedProduct` instead of `Product` * `choose_page.dart`: now using `FetchedProduct` instead of `Product` * `continuous_scan_model.dart`: now using `FetchedProduct` instead of `Product` * `new_product_page.dart`: now using `FetchedProduct` instead of `Product` * `product_dialog_helper.dart`: now using `FetchedProduct` instead of `Product` * `product_page.dart`: now using `FetchedProduct` instead of `Product` * `smooth_product_card_error.dart`: added an explicit message
|
Thank you @M123-dev! I'm going to create a similar issue on off-dart, as dart is rather relaxed regarding exception management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file:
smooth_product_card_error.dart: Product Card when an exception is caughtImpacted files:
continuous_scan_model.dart: new valueScannedProductState.ERROR, used when an exception is caught during API callsmooth_product_carousel.dart: handling theScannedProductState.ERRORcaseCurrently this is what an internet error looks like:
I won't get the Nobel Prize for Design with that, but it's still better than a misleading
CircularProgressIndicator.