Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added the Open Food facts logo, changed the button to the orange theme and fixed the broken link. #30

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

Aarthy153
Copy link
Contributor

…e and corrected the play store broken link.

What

Added the Open Food facts logo, changed the button to the orange theme, and fixed the broken link.

Screenshot

image

Fixes bug(s)

#28

@Aarthy153 Aarthy153 changed the title Added the Open Food facts logo, changed the button to the orange theme and fixed the broken link. fix : Added the Open Food facts logo, changed the button to the orange theme and fixed the broken link. Dec 28, 2022
@Aarthy153 Aarthy153 changed the title fix : Added the Open Food facts logo, changed the button to the orange theme and fixed the broken link. fix: Added the Open Food facts logo, changed the button to the orange theme and fixed the broken link. Dec 28, 2022
@Aarthy153
Copy link
Contributor Author

@teolemon Requesting your review for the PR

index.html Outdated
@@ -8,7 +8,7 @@
<body>
<div class="navbar">
<div class="navbar-container">
<a href="#"><img src="img/logo_nav@3x.png" alt="Open Food Facts" width="150px"></a>
<a href="#"><img src="img/open food facts logo.png" alt="Open Food Facts" width="250px"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you normalize the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @teolemon

@teolemon
Copy link
Member

Looks good to me @Aarthy153 👍 can you just normalize the file name?
Also please note that this project is not currently deployed to production, as it looks a little bit out of sync with the new graphic charter

@Aarthy153
Copy link
Contributor Author

@teolemon Can I develop this prototype to match the official theme and colour codes of the Open food facts? So then it will suitable for the deployment right?

@Aarthy153
Copy link
Contributor Author

@teolemon I have done the required changes in the file name.

@M123-dev
Copy link
Member

M123-dev commented Jan 2, 2023

The current "mobile app" website is this one https://world.openfoodfacts.org/open-food-facts-mobile-app

In terms of design we can surely use the new one, but from a technical perspective that's a different thing,
Feel free to create a issue for that in https://github.com/openfoodfacts/openfoodfacts-server

@teolemon
Copy link
Member

teolemon commented Jan 6, 2023

I'm going to merge anyway, it will fix current issues. Thanks @Aarthy153

@teolemon teolemon merged commit 02ce570 into openfoodfacts:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants