Extract factories to separate files and fix rubocop issues #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
factories_refactor
branch
from
53d09b0
to
42f2e78
Compare
luisramos0
changed the title
luisramos0
changed the title
…e and included in spree v1.2
… a problem any longer
luisramos0
changed the title
|
|
|
maybe it deserved a review by everyone... ping @kristinalim @mkllnk let me know if there's anything else you think should be changed or improved here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #3612
Moving factories to separate files and fix rubocop issues.
Factories clean up time finally! I have been dreaming about this since a year ago when I started working on the spree upgrade :-D
It's looking good, factories.rb is now under 200 lines and no rubocop issues in any of the factories files.
Note for reviewers: commits that start with "Extract..." are only copy paste exercises.
What should we test?
Green build. Production code is not affected in any way.
Release notes
Changelog Category: Changed
Factories (support code for automated tests) is now better organized.