fix ofGet/SetBackgroundColor, replaces #1401 #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofSetBackgroundColor has never worked properly, this fixes it ofGetBackground is deprecated for ofGetBackgroundColor ofBgColor removed completely, this will break old code but was really wrong ofbBgClear removed for ofGetBackgroundAuto also renderers now have to implement: startRender endRender and windows need to call it in display. windows don't need to set anymore the vieport, clear the bg... now the renderers do that instead, before the window had to ask the renderer if it had to clear the background and with which color which was mixing the responsabilities of both classes and where that info was stored
Conflicts: libs/openFrameworks/gl/ofShader.cpp
arturoc
added a commit
that referenced
this pull request
Oct 18, 2014
fix ofGet/SetBackgroundColor, replaces #1401
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofSetBackgroundColor has never worked properly, this fixes it
ofGetBackground is deprecated for ofGetBackgroundColor
ofBgColor removed completely, this will break old code but was really wrong
ofbBgClear removed for ofGetBackgroundAuto
also renderers now have to implement:
and windows need to call it in display.
windows don't need to set anymore the vieport, clear the bg...
now the renderers do that instead, before the window had to ask
the renderer if it had to clear the background and with which
color which was mixing the responsabilities of both classes and where
that info was stored
i've tested everything except EGL and iOS but the change in the windows is simple so they should work without problem