Skip to content

Conversation

mattfelsen
Copy link
Member

TL;DR There was a LF/CRLF issue when parsing addons.make

The first time I tried this, instead of seeing the message about local addons, I got the warning about missing addons for both my standard & local addons. I thought this could've been because I opened the gui, then changed my OF path, and maybe it didn't rescan the addons folder? But even after relaunching the gui with the OF path already set I was still seeing it.

pg-local-addons

pg-local-addons-settings

I ran the pg from the command line with the same paths to make sure that worked, and that looked good:

C:\Users\mattfelsen\Code\openFrameworks\github\apps\projectGenerator\projectGeneratorElectron\app>projectGenerator.exe -o"C:\Users\mattfelsen\Code\Projects\CMA2\openFrameworks" --addons="ofxGui,ofxOpenCv,../../ExternalAddons/ofxGrabCam" C:\Users\mattfelsen\Code\Projects\CMA2\Sketches\SilhouettesFromPointCloud

[notice ] -----------------------------------------------
[notice ] setting OF path to: C:\Users\mattfelsen\Code\Projects\CMA2\openFrameworks
[notice ] from -o option
[notice ] target platform is: vs
[notice ] updating project C:\Users\mattfelsen\Code\Projects\CMA2\Sketches\SilhouettesFromPointCloud
[notice ] saving addons.make
[notice ] project updated!
[notice ] -----------------------------------------------


1 project updated [notice ] in 1.1875 seconds

Then when going back to the gui I saw it was showing the correct warning:

pg-local-addons-working

When I git diff on addons.make there are no content changes but there's a notice on line-endings:

$ git diff Sketches/SilhouettesFromPointCloud/addons.make
warning: LF will be replaced by CRLF in Sketches/SilhouettesFromPointCloud/addons.make.
The file will have its original line endings in your working directory.

Sure enough, if I clear the changes to addons.make the gui went back to saying the addons were missing. So I just added a trim() on the strings.

@mattfelsen mattfelsen mentioned this pull request Oct 19, 2015
ofZach added a commit that referenced this pull request Oct 28, 2015
Trim whitespace/newlines when parsing addons
@ofZach ofZach merged commit b78918f into openframeworks:master Oct 28, 2015
@ofZach
Copy link
Contributor

ofZach commented Oct 28, 2015

thanks!

@mattfelsen mattfelsen deleted the addons-trim-crlf branch October 29, 2015 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants