Skip to content

skipping some addons #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2015
Merged

skipping some addons #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da31bd
skipping some addons
taiwanesePortrait Oct 28, 2015
40506ed
smarter filtering
taiwanesePortrait Oct 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions projectGeneratorElectron/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,17 @@ console.log("detected platform: " + hostplatform + " in " + __dirname);

var defaultOfPath = obj["defaultOfPath"];
var addons;

// hide some addons, per https://github.com/openframeworks/projectGenerator/issues/62

var addonsToSkip = [
"ofxiOS",
"ofxMultiTouch",
"ofxEmscripten",
"ofxAccelerometer",
"ofxAndroid"
]

var platforms = {
"osx": "OS X (Xcode)",
"vs": "Windows (Visual Studio 2015)",
Expand Down Expand Up @@ -289,6 +300,11 @@ function parseAddonsAndUpdateSelect(arg) {
console.log("in parseAddonsAndUpdateSelect " + arg);
//path = require('path').resolve(__dirname, defaultOfPath + "/addons");
addons = getDirectories(arg + "/addons","ofx");

addons = addons.filter( function(addon) {
return addonsToSkip.indexOf(addon)==-1;
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work but in javascript you have this nice functional operators for collections where you can do something like:

addons = addons.filter( function(addon) {
    return !addonsToSkip.contains(addon);
});

which means: for addons, keep only those which are not contained in addonsToSkip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool -- but I get "addonsToSkip.contains is not a function" error....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, might be a later addition, i think includes instead of contains should work and this should work for sure:

addons = addons.filter( function(addon) {
    return addonsToSkip.indexOf(addon)==-1;
});

console.log("Reloading the addons folder, these were found:");
console.log(addons);
mainWindow.webContents.send('setAddons', addons);
Expand Down