open in IDE

[ofZach]

this adds an open in IDE button on success which seems like the simplest way to add this feature (we can work on a better system post 0.9). It only works on OSX at the moment.

this PR also fixes a bug with filtering out addons that causes an error when you have the array path wrong (and thus the addon array is null)

[ofZach]

@mattfelsen: what is the command to launch the IDE on windows ? ie, on on osx "open .....xcodeproj"
@arturoc: what is the command to launch the IDE on linux?

[mattfelsen]

ooh, shiny! also, great question! i'll see if I can figure it out now. for linux, you can try xdg-open $DESTINATION_PATH from @thomasgeissl's comment here

[ofZach]

PS: this PR also puts the actual command line command at the bottom of the IDE message, which could be useful for debugging, etc:

[mattfelsen]

+1 for that. The parentheses seem like it'd be easy to accidentally copy the closing parenthesis though?

For windows, both of these are working for me:
start relative\path\to\project\project.sln
or
start C:\absolute\path\to\project\project.sln

[ofZach]

ok added windows and linux now, invites testing !

@mattfelsen do you think I should drop the parens? I kind of thought it was weird without context but maybe we can say command used:\n....... instead of parentheses)

[ofZach]

PS: for basic testing, if you are not building electron, you can replace out index.html, index.js and app.js in the nightly...

[mattfelsen]

Button is working for me, both using npm start and running the exe from the dist folder.

On a UX note, I think hitting the button should close the modal, just as the Close button does. It seems weird to close visual studio and see the pg with that modal still up.

And yea, no parens and a newline is what I was thinking 😊

[ofZach]

good idea about closing the modal... just added that.

will take a look at the parens in a sec. thanks for the feedback!

[arturoc]

we don't use codeblocks anymore in linux, the extension is qbs for qtcreator.

[ofZach]

oh ok ! let me update the labels... is this accurate:

[arturoc]

yes

[ofZach]

ok made that change ! thanks !

[mattfelsen]

very fond of this line: console.log("sdfsadfasdf?");

[ofZach]

oof thanks -- cleaned it up

[ofZach]

going to merge this in so folks can test on the nightlies, etc... I think it's ok, there might be some weird edge cases like when you build with multiple platforms or make a project that's not your default platform...

[Daandelange]

Tested and works great here :)