Skip to content

Conversation

ofZach
Copy link
Contributor

@ofZach ofZach commented Oct 29, 2015

this adds a missing .icns file. On osx this work, but I'm not 100% sure about icons on other platforms:

screen shot 2015-10-29 at 10 07 02 am

@ofZach
Copy link
Contributor Author

ofZach commented Oct 29, 2015

this PR has a funny name, but you get the idea :)

@mattfelsen
Copy link
Member

I might be opening a whole can of worms here, but... I kind of got attached to that circular electron one with the white border, so I took a quick stab and marrying that with the OF logo. Good/bad? Also I don't know how to turn this into an .icns file but here's a 1024x1024 png

of-electron

@ofZach
Copy link
Contributor Author

ofZach commented Oct 29, 2015

ok ! switched it up (I use icns builder)....

now looks like:

screen shot 2015-10-29 at 10 32 40 am

@mattfelsen
Copy link
Member

hawt

@ofZach
Copy link
Contributor Author

ofZach commented Oct 29, 2015

merging this in now...

@ofZach ofZach closed this Oct 29, 2015
@ofZach ofZach reopened this Oct 29, 2015
ofZach added a commit that referenced this pull request Oct 29, 2015
@ofZach ofZach merged commit fb3fbf7 into master Oct 29, 2015
@mattfelsen
Copy link
Member

@arturoc arturoc deleted the icon branch December 22, 2015 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants