Skip to content

Conversation

ofZach
Copy link
Contributor

@ofZach ofZach commented Nov 7, 2015

this is a potential fix for this issue:

#77

needs testing...

@ofZach
Copy link
Contributor Author

ofZach commented Nov 7, 2015

this doesn't seem to work :(

but this seems to help:

if( arg.platform == 'osx' || arg.platform == 'linux' || arg.platform == 'linux64' ){
    pgApp = pgApp.replace(/ /g, '\\ ');
} else {
    pgApp = "\"" +  pgApp + "\"";
}

open in IDE seems broken, digging into this...

@ofZach
Copy link
Contributor Author

ofZach commented Nov 7, 2015

this works well for me on windows path with spaces (open in ide works now, generating works)... going to check osx then merge.

@ofZach
Copy link
Contributor Author

ofZach commented Nov 8, 2015

this seems good on osx now (open in IDE on osx was broken but is fixed now...)

ofZach added a commit that referenced this pull request Nov 8, 2015
fix for windows spaces, needs testing
@ofZach ofZach merged commit 87796c1 into master Nov 8, 2015
@ofZach ofZach deleted the windowsSpaceFix branch November 8, 2015 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants