-
Notifications
You must be signed in to change notification settings - Fork 565
Reintroduce commit metadata in the final image #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Dockerfile was updated to add a new build argument Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
53-54
: Add an OCI label for easier metadata discovery
Settingorg.opencontainers.image.revision
helps tooling (docker inspect
, registries, SBOM generators) find the commit without running the container.ARG GIT_COMMIT=unknown ENV GIT_COMMIT="$GIT_COMMIT" +# OCI image metadata +LABEL org.opencontainers.image.revision="$GIT_COMMIT"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
🔇 Additional comments (1)
Dockerfile (1)
53-54
: Nice: commit info now survives into final image
Re-declaring the build arg in this stage is necessary because Docker resets ARG scope per stage. Promoting it to an ENV makes the value readable at runtime. Looks correct and solves the earlier regression.
The base branch was changed.
I think this should go into the v25 branch |
05afa63
to
7627f93
Compare
## Description: This PR fixes a regression where the `GIT_COMMIT` environment variable was no longer available in the final container image after a recent Dockerfile refactoring. ## Please complete the following: - [X] I have added screenshots for all UI updates - [X] I process any text displayed to the user through translateText() and I've added it to the en.json file - [X] I have added relevant tests to the test directory - [X] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [X] I have read and accepted the CLA agreement (only required once). ## Please put your Discord username so you can be contacted if a bug or regression is found: aaa4xu
Description:
This PR fixes a regression where the
GIT_COMMIT
environment variable was no longer available in the final container image after a recent Dockerfile refactoring.Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
aaa4xu