Skip to content

Conversation

Aotumuri
Copy link
Member

@Aotumuri Aotumuri commented Aug 8, 2025

Description:

mls for v25
Version identifier within MLS: v4.4

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
  • I have read and accepted the CLA agreement (only required once).

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

Copy link
Contributor

coderabbitai bot commented Aug 8, 2025

Walkthrough

This change updates multiple language JSON files to add new translation keys for privacy policy, terms of service, factories, and advertisement loading messages. It also introduces a new Slovak translation file and updates the language selector to support Slovak. Minor corrections and improvements are made in some existing translations.

Changes

Cohort / File(s) Change Summary
Bulgarian, Danish, Esperanto, Finnish, French, Galician, Japanese, Dutch, Russian, Slovenian, Swedish, Ukrainian, Chinese language updates
resources/lang/bg.json, resources/lang/da.json, resources/lang/eo.json, resources/lang/fi.json, resources/lang/fr.json, resources/lang/gl.json, resources/lang/ja.json, resources/lang/nl.json, resources/lang/ru.json, resources/lang/sl.json, resources/lang/sv-SE.json, resources/lang/uk.json, resources/lang/zh-CN.json
Added translation keys for "privacy_policy", "terms_of_service", "factories", and "spawn_ad.loading". Some files also add or correct unit type or menu descriptions.
New Slovak translation
resources/lang/sk.json
Added a full Slovak translation JSON file covering all UI and game text.
Language selector update
src/client/LangSelector.ts
Imported Slovak translation and added it to the language map for selection.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LangSelector
    participant LanguageFiles

    User->>LangSelector: Selects language (e.g., Slovak)
    LangSelector->>LanguageFiles: Loads selected language JSON
    LanguageFiles-->>LangSelector: Returns translation data
    LangSelector-->>User: Displays UI in selected language
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • mls (v4.4) #1753: Contains identical localization additions and Slovak language integration, overlapping directly with this PR.

Suggested reviewers

  • evanpelle
  • scottanderson

Poem

New words bloom in every tongue,
Slovak joins the global song.
Factories, ads, and privacy—
All translated, clear to see!
A world of languages, side by side,
In code and menus, joy and pride.
🌍✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2ac981 and 47c3f15.

📒 Files selected for processing (15)
  • resources/lang/bg.json (3 hunks)
  • resources/lang/da.json (4 hunks)
  • resources/lang/eo.json (3 hunks)
  • resources/lang/fi.json (3 hunks)
  • resources/lang/fr.json (3 hunks)
  • resources/lang/gl.json (3 hunks)
  • resources/lang/ja.json (3 hunks)
  • resources/lang/nl.json (3 hunks)
  • resources/lang/ru.json (3 hunks)
  • resources/lang/sk.json (1 hunks)
  • resources/lang/sl.json (3 hunks)
  • resources/lang/sv-SE.json (3 hunks)
  • resources/lang/uk.json (8 hunks)
  • resources/lang/zh-CN.json (3 hunks)
  • src/client/LangSelector.ts (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/client/LangSelector.ts
🚧 Files skipped from review as they are similar to previous changes (14)
  • resources/lang/ja.json
  • resources/lang/ru.json
  • resources/lang/fr.json
  • resources/lang/sv-SE.json
  • resources/lang/da.json
  • resources/lang/zh-CN.json
  • resources/lang/fi.json
  • resources/lang/sk.json
  • resources/lang/nl.json
  • resources/lang/sl.json
  • resources/lang/eo.json
  • resources/lang/bg.json
  • resources/lang/gl.json
  • resources/lang/uk.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Aotumuri Aotumuri self-assigned this Aug 8, 2025
@Aotumuri Aotumuri added the Translation Addition or modification of a language to the translations. label Aug 8, 2025
@Aotumuri Aotumuri added this to the v24 milestone Aug 8, 2025
Duwibi
Duwibi previously approved these changes Aug 8, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Aug 8, 2025
@github-project-automation github-project-automation bot moved this from Triage to Final Review in OpenFront Release Management Aug 8, 2025
@scottanderson scottanderson modified the milestones: v24, v25, v26 Aug 8, 2025
Copy link
Contributor

@scottanderson scottanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to target v25? The v24 branch has been closed for almost a week.

@github-project-automation github-project-automation bot moved this from Final Review to Development in OpenFront Release Management Aug 8, 2025
@Aotumuri
Copy link
Member Author

Aotumuri commented Aug 8, 2025

Did you mean to target v25? The v24 branch has been closed for almost a week.

Sorry, I made a mistake

@drillskibo
Copy link
Contributor

Is this for v25 release, or for v26?

@scottanderson
Copy link
Contributor

@Aotumuri are you going to update this PR for v25?

@Aotumuri
Copy link
Member Author

Aotumuri commented Aug 9, 2025

This is for v25.

@github-project-automation github-project-automation bot moved this from Development to Complete in OpenFront Release Management Aug 9, 2025
@drillskibo drillskibo modified the milestones: v26, v25 Aug 9, 2025
@drillskibo drillskibo reopened this Aug 9, 2025
@github-project-automation github-project-automation bot moved this from Complete to Triage in OpenFront Release Management Aug 9, 2025
@drillskibo drillskibo changed the base branch from main to v25 August 9, 2025 09:25
@drillskibo drillskibo dismissed stale reviews from coderabbitai[bot] and Duwibi August 9, 2025 09:25

The base branch was changed.

@drillskibo drillskibo requested a review from a team as a code owner August 9, 2025 09:25
@drillskibo
Copy link
Contributor

See #1764

@drillskibo drillskibo closed this Aug 9, 2025
@github-project-automation github-project-automation bot moved this from Triage to Complete in OpenFront Release Management Aug 9, 2025
@scottanderson scottanderson mentioned this pull request Aug 9, 2025
5 tasks
@Aotumuri Aotumuri reopened this Aug 10, 2025
@github-project-automation github-project-automation bot moved this from Complete to Triage in OpenFront Release Management Aug 10, 2025
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2025

CLA assistant check
All committers have signed the CLA.

@scottanderson scottanderson enabled auto-merge (squash) August 10, 2025 03:56
@scottanderson scottanderson disabled auto-merge August 10, 2025 03:57
@scottanderson scottanderson merged commit 7036a96 into openfrontio:v25 Aug 10, 2025
14 of 16 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Complete in OpenFront Release Management Aug 10, 2025
@coderabbitai coderabbitai bot mentioned this pull request Aug 15, 2025
5 tasks
scottanderson pushed a commit that referenced this pull request Aug 18, 2025
## Description:

mls for v25
Version identifier within MLS: v4.4

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I have read and accepted the CLA agreement (only required once).

## Please put your Discord username so you can be contacted if a bug or
regression is found:

aotumuri
@coderabbitai coderabbitai bot mentioned this pull request Sep 7, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Addition or modification of a language to the translations.
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

5 participants