Feature/international-calendar #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89e13ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lebaudantoine
force-pushed
the
feature/international-calendar
branch
from
92345b1
to
f1f0d07
Compare
lebaudantoine
changed the title
DatePicker docsDatePicker component
lebaudantoine
added
improvement
and removed
documentation
lebaudantoine
changed the title
DatePicker component
lebaudantoine
force-pushed
the
feature/international-calendar
branch
from
f1f0d07
to
1a7451f
Compare
lebaudantoine
changed the title
10 tasks
AntoLC
reviewed
Jun 27, 2023
lebaudantoine
commented
Jun 27, 2023
Comment on lines
84
to
85
| currentLocale: | ||
| (locales[currentLocale] && currentLocale) || DEFAULT_LOCALE, |
There was a problem hiding this comment.
This logic could be factorized with the locale computation. WDYT @jbpenrath ?
There was a problem hiding this comment.
Would you want me to add a test for this new feature ?
lebaudantoine
changed the title
lebaudantoine
force-pushed
the
feature/international-calendar
branch
2 times, most recently
from
b7388d6
to
54ab037
Compare
AntoLC
approved these changes
Jun 28, 2023
lebaudantoine
force-pushed
the
feature/international-calendar
branch
5 times, most recently
from
8026ddc
to
6cef84a
Compare
2 tasks
Expose `currentLocale` value to let know its subscribers what is the locale value currently in use.
Component was lacking some customization capabilities. Using the browser calendar system wasn't enough modular. This introduces a `locale` props, that allows a higher customization of the component. By default, the calendar system of the DatePicker is synchronized with the Cunningham Provider.
lebaudantoine
force-pushed
the
feature/international-calendar
branch
from
6cef84a
to
5cb45e3
Compare
Show international capabilities of the `DatePicker` component using the `locale` props and the Cunningham provider. Dates would be automatically displayed in the appropriate calendar system.
lebaudantoine
force-pushed
the
feature/international-calendar
branch
5 times, most recently
from
7892db6
to
c012f54
Compare
Documentation was outdated, as the range date picker is now available.
lebaudantoine
force-pushed
the
feature/international-calendar
branch
from
f37ed3f
to
89e13ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve international capabilities of the
DatePickercomponent using alocaleprops or the Cunningham provider. Dates would be automatically displayed in the appropriate calendar system.Proposal
currentLocalevalue in theCunninghamContext.DatePicker's calendar system withcurrentLocalevalue.localeprops to theDatePickercomponent that overridescurrentLocalevalue.DatePickercomponent using theI18nProvider.DatePickercomponent.CunninghamProviderTo be discussed
with @jbpenrath
CunninghamProvidercurrent modifications and potential refactoring.