✨(react) Datepicker position #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 419d61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AntoLC
force-pushed
the
feature/anthony/datepicker-position
branch
6 times, most recently
from
22f0a73
to
8396d68
Compare
1 task
jbpenrath
reviewed
Aug 4, 2023
AntoLC
force-pushed
the
feature/anthony/datepicker-position
branch
4 times, most recently
from
38f9330
to
35240d7
Compare
AntoLC
force-pushed
the
feature/anthony/datepicker-position
branch
2 times, most recently
from
f773486
to
669d8ab
Compare
jbpenrath
reviewed
Aug 11, 2023
AntoLC
force-pushed
the
feature/anthony/datepicker-position
branch
from
669d8ab
to
4d65cfd
Compare
Some scripts had errors when running on windows. We now use some cross platform cli tools to be able to run the scripts on every platform.
If we work from an app perspective, it is nice to have a watch mode on our packages to see the changes in real time. Better to use the watch mode of vite (rollup) compare to nodemon because it is faster, we re-transpile only the files that have changed. Possility to use the wath mode by polling as well, on a remote machine the HMR does not work well, the polling mode helps to solve this issue.
Eslint extension highlighted some issues with the way we were importing the tsconfig.json file in the .eslintrc.json file. By changing the extension to .cjs, we are now able to set tsconfigRootDir to the root of the package thanks to `dirname`. It helps eslint to find the correct tsconfig.json file.
jbpenrath
force-pushed
the
feature/anthony/datepicker-position
branch
from
931b8c6
to
757cfb6
Compare
Prettier had some missing extensions in the config, this commit added them, we then prettified the whole project. We ignore the `cunningham-tokens` files.
jbpenrath
force-pushed
the
feature/anthony/datepicker-position
branch
2 times, most recently
from
08b7d9d
to
1a6db4e
Compare
There was a problem hiding this comment.
A few nit-picking remarks 🌟 and a conversation about the refined UX 👀
Are the following behaviors expected? Let's discuss it; there might be an issue within the code. The popover position should update upon scrolling and close when necessary. WDYT?
Enregistrement.de.l.ecran.2023-08-17.a.22.08.46.mov
Enregistrement.de.l.ecran.2023-08-17.a.22.08.03.mov
In general, @jbpenrath, should we establish a standardized branching model for the project? I had it on my to-do list to initiate a conversation regarding this in the Tech channel. I'm more than willing to take that step.
Position the datepicker on top of the input when the input is at the bottom of the screen and whenthere is enough space to display the datepicker on the top.
jbpenrath
force-pushed
the
feature/anthony/datepicker-position
branch
from
ce80a59
to
419d61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We have a problem on marsha and LTI with the datepicker not accessible (see conversation).
The goal is to change the position of the datepicker depend of the place available in the screen.
Proposal
If not enough place on the bottom and enough place on the top, we place it to the top, otherwise to the bottom.
Vite.+.React.+.TS.webm
Review
Extra check here, I don't think that you need nodemon to watch the project when you do
yarn devon react packages, the vite HMR seems to be activated by default when you startstorybook, but maybe I misinterpreted something.Not sure if it is the correct way to do:
https://github.com/openfun/cunningham/blob/8396d6892f5b4a5186ad05e21c71db4c16e43008/.changeset/wet-keys-occur.md