Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of Clauses 4 terms and 5 Conventions #64

Merged
merged 5 commits into from
Jan 7, 2019

Conversation

EmDevys
Copy link
Contributor

@EmDevys EmDevys commented Jan 6, 2019

taking account of comments from Reese Plews

taking account of comments from Reese Plews

=== rectified grid
__georectified grid__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rectified grid / georectified grid are not mentionned elsewhere than in this section. To be deleted ? orthorectified is mentionned in annex-b as can be seen below and we have an entry for it already

$ grep -r "rectified" .
./clause_4_terms_and_definitions.adoc:=== georectified grid
./clause_4_terms_and_definitions.adoc:__rectified grid__
./clause_4_terms_and_definitions.adoc:Note 1 to entry:	If the coordinate reference system is related to the earth by a datum, the grid is a georectified grid.
./clause_4_terms_and_definitions.adoc:=== orthorectified grid
./clause_4_terms_and_definitions.adoc:georectified grid created using ground control points and elevation data where constant scale is maintained throughout the grid
./annex-b.adoc:      Case 5: The raster data cannot be fit into the model space with a simple affine transformation (rubber-sheeting required). Use only the ModelTiepoint tag, and specify as many tiepoints as your application requires. Note, however, that this is not a Baseline GeoTIFF implementation, and should not be used for interchange; it is recommended that the image be geometrically rectified first, and put into a standard projected coordinate reference system.
./annex-b.adoc:We have an aerial photo which has been orthorectified and resampled to a UTM grid, zone 60, using WGS 84 coordinate reference system; the coordinates of the upper-left corner of the image is are given in easting/northing, as 350807.4m, 5316081.3m. The scanned map pixel scale is 100 meters/pixels (the actual dpi scanning ratio is irrelevant).
./annex-b.adoc:===== Unrectified Aerial photo, known tiepoints, in degrees.

=== referenceable grid
__georeferenceable grid__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referenceable grid / georeferenceable grid is not not mentionned elsewhere than in this section. To be deleted ?

$ grep -r referenceable .
./clause_4_terms_and_definitions.adoc:=== referenceable grid

@EmDevys
Copy link
Contributor Author

EmDevys commented Jan 7, 2019 via email

Addition of "This document uses the terms defined in Sub-clause 5.3 of [OGC 06-121r8]" (which was unduly in clause 4 and applies to clause 7)
@rouault
Copy link
Contributor

rouault commented Jan 7, 2019

But the orthorectified grid / orthoimage entry is also using (in its 2nd definition) based on “georectified grid” term, so I guess this is correct.

indeed

EmDevys and others added 3 commits January 7, 2019 17:10
@cmheazel cmheazel merged commit 88a3fb3 into opengeospatial:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants