Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed old test report of TestNG test suites is erroneous #251

Closed
dstenger opened this issue Oct 10, 2017 · 5 comments
Closed

Detailed old test report of TestNG test suites is erroneous #251

dstenger opened this issue Oct 10, 2017 · 5 comments
Assignees
Milestone

Comments

@dstenger
Copy link
Contributor

Workflow to reproduce bug:

  • Execute ets-wfs20 via Web Browser Interface.
  • Result is HTML report. -> Go to bottom of page and navigate to See the detailed old test report..
  • Following content is erroneous:
    1. Navigate to View Details of Test tns:Main. -> Overview of all tests should be shown but test logging is shown instead.
    2. Link to See the detailed test report. is missing.

The correct behaviour can be reproduced with production [1] and the erroneous with beta [2].

[1] http://cite.opengeospatial.org/teamengine/
[2] http://cite.opengeospatial.org/te2/

@keshavnangare
Copy link
Contributor

We investigated this issue an found commit which is affecting this result.

From this commit above issue is producing: 0d7db9c

But in this commit I didn't change anything related to logging and testng result file.

I have added the one dependency commons-io in pom.xml of teamengine-spi module. Maybe this dependency is affecting to generate this result.

Currently I trying to remove this dependency and finding alternative dependency for it. I will check, is it works or not after removing this dependency.

Thank you.

@lgoltz
Copy link
Contributor

lgoltz commented Oct 16, 2017

As far as I see the html file is nor created during the test run with version 5.0 of the teamengine. That's why the link to the detailed test report is missing.
Can this be related to the changes made for EARL reporting?

@lgoltz
Copy link
Contributor

lgoltz commented Oct 18, 2017

The transformation from the test-results to the HTML (based on testng) is triggered in the CTL of the Test-Suite (e.g wfs-suite.ctl) in the template tns:testng-report. The transformation is executed, but the template does not match. The problem is that the xml to transform is the rdf/earl document, not the expected testng-result. The log in the console is also corrupt as it is not transformed for the same reasons.

The changes on com.occamlab.te.spi.executors.testng.TestNGExecutor#getPreferredMediaType() from the commit above leads to this behaviour as the default media type is now "application/rdf+xml" and not "application/xml". For the execution with the Web GUI the old behaviour should be restored.

@lgoltz lgoltz added this to the 5.0.1 milestone Oct 18, 2017
@lgoltz lgoltz self-assigned this Oct 19, 2017
@lgoltz
Copy link
Contributor

lgoltz commented Oct 19, 2017

PR #253 includes PR #254 which should be verified and merged first.

@dstenger
Copy link
Contributor Author

dstenger commented Oct 25, 2017

Testing was successful:

Internal SoapUI test runs successfully.

Internal Selenium tests confirm that fix solves the reported problem.

All tests will be made available soon: https://github.com/opengeospatial/teamengine/wiki/Tests-for-TEAM-Engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants