Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox editor widget losing binding to value (fixes #4287) #4291

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix checkbox editor widget losing binding to value (fixes #4287) #4291

merged 1 commit into from
May 17, 2023

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented May 17, 2023

No description provided.

@nirvn nirvn mentioned this pull request May 17, 2023
Closed
@qfield-fairy
Copy link
Collaborator

🎉 Ta-daaa, freshly created APKs are available for 2450783: arm64-android

Other architectures

suricactus
suricactus approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, code looks good!

Took me a while to follow with the double negation !isNull ? !value : true, but I see the rest of the code was already like this.

@nirvn nirvn merged commit 711c4ef into master May 17, 2023
@nirvn nirvn deleted the checkbox_fix branch May 17, 2023 09:26
@qfield-fairy qfield-fairy mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirvn @qfield-fairy @suricactus