Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value map value filtering case insensitive #5358

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Jun 19, 2024

@domi4484 , a quick follow up on the nice feature you developed.

@qfield-fairy
Copy link
Collaborator

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

One simple cool feature I like on searches like this is when one types all lowercase, then it is CaseInsensitive, but as soon there is a capital letter, it becomes CaseSensitive. What do you think, can we add this in the future?

@nirvn
Copy link
Member Author

nirvn commented Jun 19, 2024

@suricactus , is this a thing in other software? I would be worried that users on smartphone with keyboards auto-capitalizing the first word would end up in a case sensitive search unknowingly.

@suricactus
Copy link
Collaborator

@suricactus , is this a thing in other software? I would be worried that users on smartphone with keyboards auto-capitalizing the first word would end up in a case sensitive search unknowingly.

In some vim configurations :) . I do a agree with capitalizations on phones is hard and we still cannot force lowercase (just tested on the QFC login username with the hope qt6 did miracles).

@nirvn nirvn merged commit 18668af into master Jun 19, 2024
24 of 25 checks passed
@nirvn nirvn deleted the valuemap_search_fix branch June 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants