Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a feature-based geometry lock mechanism #548

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Dec 1, 2023

This PR implements a functionality in qfieldsync allowing users to determine the locked geometry state of individual features within a vector layer.

First, here's a screenshot of the UI:

image

A brand new data-defined property button sits next to the [x] lock geometry checkbox. From there, users can select a feature attribute or build a more complex expression that will change the locked geometry status of individual features.

(Requires opengisch/libqfieldsync#58 on the libqfieldsync side of things)

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments on the code, just clarifications on naming. Very nice it is using the same mechanism to define dynamic value as in the rest of QGIS.

qfieldsync/ui/map_layer_config_widget.ui Show resolved Hide resolved
qfieldsync/gui/map_layer_config_widget.py Show resolved Hide resolved
@nirvn nirvn force-pushed the locked_geometry branch 2 times, most recently from fd4f6f2 to 1be42a6 Compare December 2, 2023 02:12
@nirvn nirvn merged commit 52180ff into master Dec 2, 2023
7 checks passed
@nirvn nirvn deleted the locked_geometry branch December 2, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants