build: merge Release 4.56.0 into master #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge 4.54.0 into develop
Bumps [webpack](https://github.com/webpack/webpack) from 4.43.0 to 4.46.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.43.0...v4.46.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1037) Bumps [angular-translate-loader-partial](https://github.com/angular-translate/bower-angular-translate-loader-partial) from 2.18.3 to 2.18.4. - [Release notes](https://github.com/angular-translate/bower-angular-translate-loader-partial/releases) - [Commits](angular-translate/bower-angular-translate-loader-partial@2.18.3...2.18.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Snyk has created this PR to upgrade mongoose from 5.11.9 to 5.11.10. See this package in npm: https://www.npmjs.com/package/mongoose See this project in Snyk: https://app.snyk.io/org/open-government-products/project/4c4f5244-5ce5-491a-a42d-c295bc7f51fd?utm_source=github&utm_medium=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io>
…-form controller (#1045) The bug in #1044 was not reproduced. This is not a surprise as concurrency bugs are indeterministic by definition. However, based on the symptom and rarity of the bug, it is possible that the behavior is a result of edge cases caused by poor integration with AngularJS. Multiple code paths were thoroughly examined, and the appropriate refactor performed to improve code clarity and reduce the likelihood of concurrency issues. controllerState variable refactor The controllerState variable is used to store the cloned form object in the savedForm property before fields were locked/disabled. It was previously not attached to the directive scope, but simply as a const which makes it a possible candidate to resolve the concurrency bug as AngularJS would not be tracking changes to this variable during the digest cycle. submitFormMain function refactor The need to clone the form object before calling this function was removed by refactoring to avoid assigning to the form.attachment property (it is a very bad practice to mutate function arguments). This not only removed the need for an expensive clone operation, but also guarantees that there can be no divergence between the form object in the controller scope vs the one used in the submitForm function, since the call to submitForm(scope.form) is a reference to the same form object. Co-authored-by: Yuanruo Liang <yuanruo@open.gov.sg>
…ins (#1039) * refactor: move polyfills used in main JS thread into a single file * doc: add explanations for each * feat(performance): only IE11 should receive existing polyfills * docs(browser-detection): add reminder that isInternetExplorer() is not safe to call from a WebWorker context * refactor(worker): only polyfill if Promise is unavailable. * fix: avoid transpiling polyfills since they pneed to monkey patch native APIs * fix(regenerator-runtime): babel transpilation expects library to be available in global namespace * refactor(ndjson-stream): remove polyfills and document code better * fix: remove misleading comments * refactor: convert from browser detection to feature detection Co-authored-by: Yuanruo Liang <yuanruo@open.gov.sg>
mantariksh
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.