build: release v5.6.0 #1630
Merged
build: release v5.6.0 #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(corppass-ui): make ui changes for corppass - updated copy for ui - updated minimum necessary user-facing mentions of singpass and corppass to use new casing - made necessary frontend changes for corporate singpass button - added tooltip beside corppass option in settings > enable authentication - updated e2e tests for new changes * fix(start-page): increase corp login hor. padding
Bumps [@opengovsg/spcp-auth-client](https://github.com/opengovsg/spcp-auth-client) from 1.4.4 to 1.4.5. - [Release notes](https://github.com/opengovsg/spcp-auth-client/releases) - [Commits](opengovsg/spcp-auth-client@v1.4.4...v1.4.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.20.0 to 4.21.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.21.0/packages/eslint-plugin) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.6.10 to 3.6.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.3.3 to 24.3.4. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v24.3.3...v24.3.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ngrok](https://github.com/bubenshchykov/ngrok) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/bubenshchykov/ngrok/releases) - [Changelog](https://github.com/bubenshchykov/ngrok/blob/master/CHANGELOG.md) - [Commits](https://github.com/bubenshchykov/ngrok/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1558) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.20.0 to 4.21.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.21.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor(auth-api): duplicate auth endpoints to new /api/v3 router - duplicate auth endpoint functionality and update endpoints - update v3 router to use new endpoints - update frontend api calls to use new endpoints * test(auth-api): duplicate integration tests for new endpoint
* fix: package.json & package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MQUERY-1089718 * refactor(mongoose): rework type defs * refactor(models): rework form.server.model for mongoose - recast FormSchema as FormDocumentSchema so that we can register methods specific to the handling of IFormDocument - declare Schema.Types.DocumentArrayWithLooseDiscriminator so that we can more easily register our sub-schema TODO - submit a patch to mongoose to loosen the type def for `DocumentArray.discriminator()` Co-authored-by: LoneRifle <LoneRifle@users.noreply.github.com>
build: merge Release 5.5.0 into develop
…1529) * ref: narrow types for getWebhookView * ref: move hasProp to utils * ref: implement service using neverthrow * ref: implement webhook factory * ref: delete old middleware factory * ref: implement new middleware * ref: use new factory function in controller * refactor(webhook-service): add tests for webhook services - moved webhook url validation to new file and updated references - updated tests for webhook validation ref #193 * fix(build): removed duplicate type for possible-database-error * fix(webhook-service): use relative imports * fix(webhook-factory): fix feature-guard conditional * test(webhook-service) update webhook tests * refactor(tests): clean up unit and model tests * refactor(tests): do further cleaning of tests * refactor(tests): add missing calledWith checks for mocks * refactor(submission-model): clean up queries and webhook tests Co-authored-by: Antariksh <antarikshmahajan@gmail.com>
Bumps [concurrently](https://github.com/kimmobrunfeldt/concurrently) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/kimmobrunfeldt/concurrently/releases) - [Commits](kimmobrunfeldt/concurrently@v6.0.0...v6.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.14 to 1.9.16. - [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags) - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.9.14...v1.9.16) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.879.0 to 2.880.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.879.0...v2.880.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1553) * refactor(user-api): duplicate user endpoints to new /api/v3 router - duplicate user endpoint functionality and update endpoints - duplicated integration tests for new endpoint - update v3 router to use new endpoints - update frontend api calls to use new endpoints * fix(auth-client-service): add missing / * fix(v3-routes): fix import order
* refactor: Refactor attachment upload into a service * Make changes based on mantariksh@'s comments * Add formId to logging metadata for attachment uploading * remove extraneous space
* feat(public/services/billingservice): added billing service * feat(public/services/exampleservice): added example service * test(public/services/billingservice): adds tests for getBillingInfo * test(public/services/exampleservice): adds tests for getSingleExampleForm and getExampleForms * refactor(billingservice): added dto types to fe/be and type annnotation on get for fe * style(public/exampleservice): added curly braces; added type annotation on methods * refactor(examples): adds dto to params and updated fe file naming to fit be * test(examplesservice): updated tests to use new dto shape * refactor(billing): updated billing fe/be to use dto * test(billingservice): updated tests to use dto for params * refactor(examples-list/controller): updated to use ExamplesService * refactor(billing/client/controller): replaced AdminService with new BillingService * refactor(forms/client/routes): replaced AdminConsole with ExamplesService * chore(main.js): deletes old admin-console.client.service * test(billingservice): updated test blocks * test(exampleservice): updated test blocks * style(types/billing): imported LoginStatistic rather than redefining
…1577) also converted tests to Typescript tests
…ks (#1584) * test: loosen test checks due to non-deterministic mongo query * test: fix flakiness due to Date * test: remove invalid comment
Bumps [testcafe](https://github.com/DevExpress/testcafe) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/DevExpress/testcafe/releases) - [Changelog](https://github.com/DevExpress/testcafe/blob/master/CHANGELOG.md) - [Commits](DevExpress/testcafe@v1.13.0...v1.14.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.880.0 to 2.882.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.880.0...v2.882.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor(modules/spcp): shifts get spcp session out into service * refactor(modules/form): adds utility methods and refactored checkFormSubmission * refactor(modules/form): refactors GET public forms end point from js to ts * refactor(utils): adds utility type for all possible db errors * fix(types/form): fixed the type of submissionLimit to allow for null * refactor(modules/form): updated deactiveForm so that it uses never throw and adds logging * refactor(modules/form): updated form limit checking to account for submission limit being null * refactor(modules/form): adds logging to getSpcpSession * refactor(modules/form): refactored handleGetPublicForm for clarity and code cleanliness * refactor(publicformctrl): refactored handler for GET public forms to be cleaner and easier to read * refactor(spcpsvc): added logging to extract JWT; updated typings for getSpcpSession * revert(formsvc): removes retrievePublicForm (will be done in another PR) to limit scope * style(public-form/controller): updated object to use variables * style(services/types): updated documentation for functions and removed unneeded logging * refactor(public-form/controller): refactored spcp flow so it's clearer * refactor(public-form/controller): wip for myInfo * refactor(myinfo): extracts myInfoCookiePayload to 2 types and adds utility function to differentiate * refactor(public-form/controller): refactored myinfo chunk so it's neater * test(form/service): fixes failing tests due to checkFormSubmissionLimitAndDeactivateForm * refactor(myinfo): removed unneeded cookie type and updated extractSuccessfulCookie to reflect this * docs(public-form/controller): adds docs to confusing sections of handlGetPublicForm * test(public-form/controller/test): add test for database error when GET /getPublicForm * test(public-form/controller/tests): add more tests * test(public-form/controller/test): adds test for success cases * refactor(myinfo): extracts out chunks form public-form controller into myinfo service * refactor(public-form/controller): updated controller to use MyInfoFactory method * test(public-form/controller/test): updated tests to use mocks * fix(public-form/controller): fixed succesful 200 when auth using myInfo returning a private view * test(public-form/controller/test): adds remaining tests for myInfo * refactor(spcp): combined controller calls to spcp services into a single spcp call * refactor(myinfo): refactored multiple controller calls to myInfo into a single call * refactor(public-form): updated typings and refactored getPublicForm to be cleaner * style(public-form/controller/test): updated comments in tests to use when * refactor(form/service): updated deactiveForm to return the form itself; updated tests * style(myinfo): extractMyInfoData renamed to fetchMyInfoData * fix(public-form/controller): fixed bug where wrong extract cookie method is being called * refactor(spcp/myinfo): removed extra logging in spcp; updated names in myinfo * test(spcp/service/test): adds service tests * test(spcp/service/test): adds unit tests for createFormWithSpcpSession * test(myinfo.service): adds tests for createFormWithMyInfo * feat(form): adds new errors and utility methods * refactor(public-form): refactor to account for intarnet * refactor(public-form/controller): added compatability for checking intranet access * test(public-form/controller): adds tests for checking intranet; fixes old tests due to this addition * style(spcp/service/test): changed naming to camelCase for variables * fix(form.service): fixed intranet ip checking * refactor(public-form): shifts utility method out into public form service * test(public-form/controller): updates tests * refactor(public-forms/server/routes): swaps to new controller for express middleware * fix(myinfo/util): added cookie access check * fix(form/service): adds error recovery for missing feature error when checking intranet access * refactor(public-form/controller): tightened logic for myinfo error * build(package.json): added ts-essential for UnreachableCaseException * refactor(forms): added new type for intranet form * refactor(spcp/service): updated service methods * refactor(intranet/factory): updated isIntranetIp and factory signature typings * refactor(myinfo): updated typings and factory methods to remove responsibility from service * refactor(public-form/controller): wip * refactor(form/service): remove result wrapping as only error is MissingFeatureError * refactor(myinfo): updated typings and comments for myInfo * refactor(publicform): updated handleGetPublicForm method and removed unused types * refactor(public-form/service): removed unnused method * fix(public-form/controller): changed returned form to be a publicForm * test(myinfo/service): updated tests for myinfo service * test(public-form/controller): updated tests to fit iwth refactor * chore(intranet): removed unused variables * test(intranet/service): fixes failing tests due to refactor * refactor(app/utils): removed duplicate datatype in handle mongo errors * style(form/service): updated logger message * test(spcp/service): removed tests for deleted method; updated test for getSpcpSession * refactor(public-form/controller): extracts logger meta property into a variable * style(form/service): updated action property of logger meta * docs(public-form/controller): updated comments for getPublicForm on conditions for myInfoError * refactor(myinfo): deleted unused middleware; made fetchMyInfoPersonData private * refactor(myinfo): changed fetchMyInfoPersonData to become a private field * test(myinfo): fixed factory and service tests due to making myInfoPersonData private * chore(webhook/service/test): fixed import * chore(types/forms): removed unused type declaration * style(form/service): chains calls together for clarity * refactor(myinfo): refactored methods so that atomic operations are performed together * test(myinfo): fixes tests for myinfo * style(spcp): renamed service methods for clarity; removed unused error * test(spcp): fixes spcp tests * refactor(public-form): updated controller to account for myinfo/spcp refactoring * test(public-form): updated tests * fix(public-form/controller): fixed cp returning userInfo as ewll
Bumps [@types/bcrypt](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/bcrypt) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/bcrypt) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: merge release v5.5.1 back to develop
* test: replace usages of ts-mock-imports with jest mocks apparently unneeded * chore: remove sinon and ts-mock-imports
* chore: inline model tests * chore: rename frontend.server.* to frontend.* * chore: inline field validator tests * chore: inline app/utils tests * chore: move loaders and config into src/app * chore: fix mock paths * docs: update ARCHITECTURE.md * chore: move shared tests into shared
…1573) * refactor(misc-api): duplicate misc endpoints to new /api/v3 router - duplicate bounce notifications, analytics and billing endpoints functionality and update them to use the new api v3 routes - update v3 router to use new endpoints - update frontend api calls to use new endpoints * refactor(files): organise misc-api folders and routers - rename billing to billings for clarity - add notifications router between v3 and bounce for clarity - update router responsibilities for clarity * refactor(misc-api): update file and router names * fix(billings-tests): update billings tests to match merged changes
* feat(helpers/jest-db): adds util methods to get/update form while testing * test(public-form/routes): adds integration tests for public-form * chore(helpers/jest-db): removed unused helper method * fix(public-form/controller): fixed regression issues where certain fields were missed * test(public-form): fixed tests so that privateFormError is checked correctly
* test: fix flaky form feedback test * ref: use compareAsc from date-fns
…ller into chains (#1622)
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.5 to 4.2.4. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.1.5...v4.2.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.21.0 to 4.22.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.22.0/packages/eslint-plugin) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.20.1 to 2.20.2. - [Release notes](https://github.com/date-fns/date-fns/releases) - [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md) - [Commits](date-fns/date-fns@v2.20.1...v2.20.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1627) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.21.0 to 4.22.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.22.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [winston-cloudwatch](https://github.com/lazywithclass/winston-cloudwatch) from 2.5.1 to 2.5.2. - [Release notes](https://github.com/lazywithclass/winston-cloudwatch/releases) - [Changelog](https://github.com/lazywithclass/winston-cloudwatch/blob/master/CHANGELOG.md) - [Commits](https://github.com/lazywithclass/winston-cloudwatch/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Tests/api/v3/user
/api/v3/statistics
/api/v3/billings
|
|
@mantariksh (sorry you are the only other person with GSIB) TestsCan probably do this alongside IE11/GSIB tests /adminform refactorAll /adminform endpoints should work as is;
EncryptSubmissionRouter
fix double download of csv
Public form
Intranet IE11 runthrough
|
Testsemail preview submission middleware collapse
encrypt preview submission middleware collapse
|
TestsBounce neverthrow
|
Testsadmin-console client service
|
Tests/frontend route refactor
|
Testspublic form api refactorstorage mode
email mode
|
Testswebhook server service neverthrow
|
mantariksh
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v5.6.0
This release includes quite a bit of Typescript migration and improvements, as well as first bits of API refactors from their current routes to clearer
/api/v3/rooted routes.Features
#1573#1553#1551Improvements
#1562#1623#1606#1592#1567#1561#1554#1591#1531#1405#1595#1621#1547#1596#1398#1622#1529#1604#1620#1578#1587#1572Fixes
#1584#1590#1577Dependency changes
#1611#1555(https://github.com/fix(deps): bump @opengovsg/spcp-auth-client from 1.4.4 to 1.4.5 #1555)#1538#1570#1585#1609#1615#1569#1601#1618#1614#1626#1600#1602#1599#1619#1557#1556#1625#1558#1627#1568#1608#1607#1617#1628#1613#1559#1616#1560#1580#1624