Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove has-ansi package #2781

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Sep 12, 2021

Removed has-ansi package as the package owner has converted it to an ES module, without any CommonJS alternatives. I was not going to convert the entire codebase into an ESM codebase. On further inspection, probably didn't need the has-ansi package since that package was used entirely for local development.

Something we can do down the line is probably overhaul the logging file to something like roosevelt-logger

Outdated

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIREGEX-1583908
Yes Proof of Concept
Commit messages
Package name: has-ansi The new version differs by 2 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

@karrui
Copy link
Contributor

karrui commented Sep 13, 2021

I'll pick this up

@karrui karrui changed the title [Snyk] Security upgrade has-ansi from 4.0.1 to 5.0.0 chore(deps): remove has-ansi package Sep 13, 2021
snyk-bot and others added 2 commits September 21, 2021 11:35
Seems to be alright, only affects local dev environment anyways. Not worth converting the app to ESM.
See
@mantariksh mantariksh force-pushed the snyk-fix-489b78a45c0b316f816edb354dc71a1a branch from 5fe814d to 5c1218a Compare September 21, 2021 03:35
@mantariksh mantariksh merged commit 6ce7178 into develop Sep 21, 2021
@mantariksh mantariksh deleted the snyk-fix-489b78a45c0b316f816edb354dc71a1a branch September 21, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants