Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v5.29.0 #2850

Merged
merged 28 commits into from Sep 22, 2021
Merged

build: release v5.29.0 #2850

merged 28 commits into from Sep 22, 2021

Conversation

mantariksh
Copy link
Contributor

Improved

  • refactor: update NRIC validation #2842
  • chore(deps): remove has-ansi package #2781

Internal

  • feat: Datadog agent integration #2824
  • build(mergify): specify checks and include Snyk #2825

Dependency upgrades

App dependencies

  • fix(deps): bump fp-ts from 2.11.2 to 2.11.3 #2847
  • fix(deps): bump aws-sdk from 2.991.0 to 2.992.0 #2846
  • fix(deps): bump @sentry/integrations from 6.12.0 to 6.13.2 #2844
  • fix(deps): bump @sentry/browser from 6.13.1 to 6.13.2 #2843
  • fix(deps): bump date-fns from 2.23.0 to 2.24.0 #2833
  • fix(deps): bump aws-sdk from 2.987.0 to 2.991.0 #2820
  • fix(deps): bump @sentry/browser from 6.12.0 to 6.13.1 #2831
  • fix(deps): bump libphonenumber-js from 1.9.32 to 1.9.34 #2810

Dev dependencies

  • chore(deps-dev): bump @types/node from 14.17.17 to 14.17.18 #2848
  • chore(deps-dev): bump jest-localstorage-mock from 2.4.17 to 2.4.18 #2845
  • chore(deps-dev): bump htmlhint from 0.15.1 to 0.15.2 #2838
  • chore(deps-dev): bump eslint-plugin-jest from 24.4.0 to 24.4.2 #2837
  • chore(deps-dev): bump @typescript-eslint/parser from 4.31.1 to 4.31.2 #2835
  • chore(deps-dev): bump @types/jest from 27.0.1 to 27.0.2 #2834
  • chore(deps-dev): bump type-fest from 2.3.2 to 2.3.4 #2832
  • chore(deps-dev): bump @types/express-request-id from 1.4.2 to 1.4.3 #2827
  • chore(deps-dev): bump @typescript-eslint/eslint-plugin #2828
  • chore(deps-dev): bump prettier from 2.4.0 to 2.4.1 #2829
  • chore(deps-dev): bump @types/node from 14.17.15 to 14.17.17 #2821
  • chore(deps-dev): bump @typescript-eslint/parser from 4.31.0 to 4.31.1 #2812

timotheeg and others added 28 commits September 14, 2021 13:39
@timotheeg
Merge pull request #2804 from opengovsg/release
9bfb73a 
build: merge release 5.28.0 into develop
@dependabot
chore(deps-dev): bump @typescript-eslint/parser from 4.31.0 to 4.31.1 (…
054aa0c 
…#2812)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.31.0 to 4.31.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@timotheeg @mantariksh
refactor: use modern JS constructs to validate NRIC (#2785)
aaa8072 
* refactor: use modern JS constructs to validate NRIC

* Feat: correct typos and var naming convention

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>

* refactor(nric-validation): rename variables to make code more self-explanatory

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
@dependabot
fix(deps): bump libphonenumber-js from 1.9.32 to 1.9.34 (#2810)
fdeed50 
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.32 to 1.9.34.
- [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.9.32...v1.9.34)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/node from 14.17.15 to 14.17.17 (#2821)
1945210 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.17.15 to 14.17.17.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
build(mergify): specify checks and include Snyk (#2825)
35c3bcf
@dependabot
fix(deps): bump aws-sdk from 2.987.0 to 2.991.0 (#2820)
a0494d1 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.987.0 to 2.991.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.987.0...v2.991.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@snyk-bot @karrui
chore(deps): remove has-ansi package (#2781)
6ce7178 
* fix: package.json & package-lock.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908

* feat: remove has-ansi package

Seems to be alright, only affects local dev environment anyways. Not worth converting the app to ESM.
See

Co-authored-by: Kar Rui Lau <karrui.lau@gmail.com>
@dependabot
chore(deps-dev): bump prettier from 2.4.0 to 2.4.1 (#2829)
4af0dfe 
Bumps [prettier](https://github.com/prettier/prettier) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.4.0...2.4.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @typescript-eslint/eslint-plugin (#2828)
0932a71 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.31.1 to 4.31.2.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.2/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/express-request-id from 1.4.2 to 1.4.3 (#…
a936738 
…2827)

Bumps [@types/express-request-id](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-request-id) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-request-id)

---
updated-dependencies:
- dependency-name: "@types/express-request-id"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/browser from 6.12.0 to 6.13.1 (#2831)
24d6c88 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.12.0 to 6.13.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.12.0...6.13.1)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump type-fest from 2.3.2 to 2.3.4 (#2832)
a1482a1 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 2.3.2 to 2.3.4.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v2.3.2...v2.3.4)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump date-fns from 2.23.0 to 2.24.0 (#2833)
d6bb77a 
Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.23.0 to 2.24.0.
- [Release notes](https://github.com/date-fns/date-fns/releases)
- [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md)
- [Commits](date-fns/date-fns@v2.23.0...v2.24.0)

---
updated-dependencies:
- dependency-name: date-fns
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/jest from 27.0.1 to 27.0.2 (#2834)
232ff3e 
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 27.0.1 to 27.0.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @typescript-eslint/parser from 4.31.1 to 4.31.2 (…
96553d9 
…#2835)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.31.1 to 4.31.2.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.31.2/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump eslint-plugin-jest from 24.4.0 to 24.4.2 (#2837)
d82b4e7 
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.4.0 to 24.4.2.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v24.4.0...v24.4.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump htmlhint from 0.15.1 to 0.15.2 (#2838)
2809136 
Bumps [htmlhint](https://github.com/htmlhint/HTMLHint) from 0.15.1 to 0.15.2.
- [Release notes](https://github.com/htmlhint/HTMLHint/releases)
- [Changelog](https://github.com/htmlhint/HTMLHint/blob/master/CHANGELOG.md)
- [Commits](htmlhint/HTMLHint@v0.15.1...v0.15.2)

---
updated-dependencies:
- dependency-name: htmlhint
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@timotheeg
fix: Revert "refactor: use modern JS constructs to validate NRIC (#2785…
a83c3ff 
…)" (#2836)

This reverts commit aaa8072.
@dependabot
fix(deps): bump @sentry/browser from 6.13.1 to 6.13.2 (#2843)
838a4cc 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.13.1 to 6.13.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.13.1...6.13.2)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 6.12.0 to 6.13.2 (#2844)
b392915 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.12.0 to 6.13.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.12.0...6.13.2)

---
updated-dependencies:
- dependency-name: "@sentry/integrations"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.991.0 to 2.992.0 (#2846)
2fe81dd 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.991.0 to 2.992.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.991.0...v2.992.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@timotheeg @mantariksh
refactor: update NRIC validation (#2842)
9d07224 
* refactor: use modern JS constructs to validate NRIC

* Feat: correct typos and var naming convention

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>

* refactor(nric-validation): rename variables to make code more self-explanatory

* fix: don't use named groups in regexp in frontend code

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
@dependabot
chore(deps-dev): bump jest-localstorage-mock from 2.4.17 to 2.4.18 (#…
a420403 
…2845)

Bumps [jest-localstorage-mock](https://github.com/clarkbw/jest-localstorage-mock) from 2.4.17 to 2.4.18.
- [Release notes](https://github.com/clarkbw/jest-localstorage-mock/releases)
- [Commits](clarkbw/jest-localstorage-mock@v2.4.17...v2.4.18)

---
updated-dependencies:
- dependency-name: jest-localstorage-mock
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@timotheeg
feat: Datadog agent integration (#2824)
6b5e113 
* feat: Add default datadog config

* feat: add formsg-specific eb changes to dd config

* feat: Add datadog connect to instrument express

* refactor: remove unecessary commented out import

* refactor(dd): remove unecessary error handler and console logging

* refactor(dd): remove incorrect comment
@dependabot
chore(deps-dev): bump @types/node from 14.17.17 to 14.17.18 (#2848)
27441ba 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.17.17 to 14.17.18.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump fp-ts from 2.11.2 to 2.11.3 (#2847)
0f5d113 
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.11.2 to 2.11.3.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](gcanti/fp-ts@2.11.2...2.11.3)

---
updated-dependencies:
- dependency-name: fp-ts
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
chore: bump version to 5.29.0
247f458
@mantariksh
Copy link
Contributor Author

mantariksh commented Sep 22, 2021 •
edited

@mantariksh

Tests

  • Test NRIC validation with several valid SPCP sample NRICs (to get the list, go to any Singpass form on staging, click Log In and click the dropdown)

@mantariksh mantariksh merged commit eb0a2df into release Sep 22, 2021
@mantariksh mantariksh deleted the release-v5.29.0 branch September 22, 2021 05:35
@karrui karrui restored the release-v5.29.0 branch September 28, 2021 05:13
@tshuli tshuli deleted the release-v5.29.0 branch September 29, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeg timotheeg timotheeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mantariksh @timotheeg @snyk-bot