build: merge release 4.46.1 into master #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model static methods (#601) * feat(SubmissionModel): add findMetadataById static method * test(EncryptSubModel): add findMetadataById tests * ref(EncryptSubModel): rename static to findSingleMetadata * feat(SubmissionModel): add findAllMetadataByFormId static method * test(EncryptSubModel): add findAllMetadataByFormId tests * feat(AdminFormsRoute): add celebrate middleware to subs metadata api * feat(EncryptSubsCtl): replace inlined queries with model static fns * refactor(Submission): loosen model types according to schema * fix(AdminFormsRoutes): import missing import * ref(SubmissionModel): move type declaration outside of function
build: merge release 4.45.0 into develop
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.6 to 14.14.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…610) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.5.0 to 4.7.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.7.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tion (#602) * chore: rename errors server controller to typescript * chore: add @types/mongodb as devdependency * chore: define MongoError interface * chore: typescripify errors server controller * chore: rename errors server controller spec to ts * chore: clean up errors.server.controller.spec.ts * refactor: use destructuring assignment for isEmpty * chore: remove types from JSDocs * chore: remove defaultErrorMessage from exports * chore: remove mongoDuplicateKeyError as only UserSchema has unique key and that is already validated * refactor: use arrow function for getMongoErrorMessage * refactor: clean up getMongoErrorMessage * chore: shift errors.server.controller to utility function * chore: update tests * chore: shift defaultErrorMessage to function parameter
* fix: use maildev for dev environment emails * docs: update README with local email instructions
Bumps [angular-aria](https://github.com/angular/angular.js) from 1.8.0 to 1.8.2. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.0...v1.8.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Backend implementation for attachment downloading using existing CSV decryption webworkers * support for downloading files in worker threads
Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongoose) from 5.7.36 to 5.7.37. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongoose) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(deps): bump jwt-decode from 2.2.0 to 3.1.1 Bumps [jwt-decode](https://github.com/auth0/jwt-decode) from 2.2.0 to 3.1.1. - [Release notes](https://github.com/auth0/jwt-decode/releases) - [Changelog](https://github.com/auth0/jwt-decode/blob/master/CHANGELOG.md) - [Commits](auth0/jwt-decode@v2.2.0...v3.1.1) Signed-off-by: dependabot[bot] <support@github.com> * fix: import jwt-decode correctly Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh <antarikshmahajan@gmail.com>
Bumps [supertest](https://github.com/visionmedia/supertest) from 5.0.0 to 6.0.1. - [Release notes](https://github.com/visionmedia/supertest/releases) - [Commits](ladjs/supertest@v5.0.0...v6.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [uuid](https://github.com/uuidjs/uuid) from 8.3.0 to 8.3.1. - [Release notes](https://github.com/uuidjs/uuid/releases) - [Changelog](https://github.com/uuidjs/uuid/blob/master/CHANGELOG.md) - [Commits](uuidjs/uuid@v8.3.0...v8.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) * feat(CoreErrors): add external errors for errors arising externally * feat(AdminFormSvc): add createPresignedPostForImages function * test(AdminFormSvc): add test cases for createPresignedPostForImages * feat(AdminFormCtl): add handleCreatePresignedPostForImages function * test(AdminFormCtl): add tests for handleCreatePresignedPostForImages * ref(AdminFormsRoutes): replace createPresignedPostForImages fn * feat: remove unused adminForms.createPresignedPostForImages fn * feat(AdminFormSvc): add JSDoc to createPresignedPostForImages * ref(AdminFormSvc): extract out core presigned code * feat(AdminFormSvc): make error message more generic on external error
Bumps [testcafe](https://github.com/DevExpress/testcafe) from 1.8.6 to 1.9.4. - [Release notes](https://github.com/DevExpress/testcafe/releases) - [Changelog](https://github.com/DevExpress/testcafe/blob/master/CHANGELOG.md) - [Commits](DevExpress/testcafe@v1.8.6...v1.9.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.1.0 to 8.2.1. - [Release notes](https://github.com/babel/babel-loader/releases) - [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md) - [Commits](babel/babel-loader@v8.1.0...v8.2.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [angular](https://github.com/angular/angular.js) from 1.8.0 to 1.8.2. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.0...v1.8.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* style: warning color for email * refactor: use class instead of id
* fix(deps): bump helmet from 4.1.1 to 4.2.0 Bumps [helmet](https://github.com/helmetjs/helmet) from 4.1.1 to 4.2.0. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md) - [Commits](helmetjs/helmet@v4.1.1...v4.2.0) Signed-off-by: dependabot[bot] <support@github.com> * fix: type assertion for mockHelmet.contentSecurityPolicy Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: shuli-ogp <shuli@open.gov.sg>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.24.2 to 5.27.3. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@5.24.2...5.27.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NODEMAILER-1038834
* feat(AdminFormSvc): add createPresignedPostForLogos function * feat(AdminFormCtl): add handler for presigning logos upload POST url * test(AdminFormSvc): add test cases for createPresignedPostForLogos * ref(AdminFormsRoute): use new logo presign post handler * test(AdminFormCtl): add tests for handleCreatePresignedPostForLogos * feat(AdminForm): replace ExternalErrors with CreatePresignedUrlError
…omponent (#569) * chore: replace '&' in ejs template * chore: remove he decoding * chore: shift stealth prefil to textfield component * chore: add tests for frontend.server.controller * chore: update package-lock * chore: add error handling to frontend.server.controller * chore: reorganize tests, add tests for invalid request * chore: log errors on frontend server controller * chore: reorganise tests * fix: relative paths * chore: standardise logger action to calling function * chore: return res
* tests: move submission module tests into module directory * feat(SubmissionSvc): add new getFormSubmissionsCount fn * test(SubmissionSvc): add tests for getFormSubmissionsCount * feat(adminFormUtils): add assertHasReadPermissions function Util function to check whether given user has read permissions to given form * ref(dateUtil): add JSDoc + stricter types for createQueryWithDateParam * ref(SubmissionSvc): allow dateRange child keys to be undefined * ref(User): move getUserIdFromSession to auth utils * feat(AdminFormCtl): add handleCountFormSubmissions handler * feat(AdminFormRoute): replace form submission count controller * feat(AdminFormRoutes): add joi validation to form submission count api * test(AdminFormCtl): add tests for handleCountFormSubmissions * feat: remove submissions.server.controller#count function and tests * test(adminFormUtils): add tests for assertHasReadPermissions * feat(AdminFormsRoute): use auth middleware in form sub counts handler * fix: remove unused imports * ref(AdminFormsRoutes): extract out YYYYMMDD regex into variable * fix(AdminFormsRoutes): use Joi.object.and instead of object.with `with` allows for a query with only `endDate` since only `startDate` is required, which is wrong
Bumps [eslint](https://github.com/eslint/eslint) from 7.12.1 to 7.13.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.12.1...v7.13.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongoose) from 5.7.37 to 5.10.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongoose) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…6.0.0 (#646) * chore(deps-dev): bump eslint-plugin-simple-import-sort Bumps [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort) from 5.0.3 to 6.0.0. - [Release notes](https://github.com/lydell/eslint-plugin-simple-import-sort/releases) - [Changelog](https://github.com/lydell/eslint-plugin-simple-import-sort/blob/main/CHANGELOG.md) - [Commits](lydell/eslint-plugin-simple-import-sort@v5.0.3...v6.0.0) Signed-off-by: dependabot[bot] <support@github.com> * fix: fix .eslintrc * chore: run lint Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antariksh <antarikshmahajan@gmail.com>
* feat(EncryptSubModel): add getSubmissionCursorByFormId static method * feat(EncryptSubSvc): add getSubmissionCursor service fn * feat(EncryptSubCtl): add handler for streaming encrypted response api * ref(AdminFormsRoutes): use migrated handler for streaming responses * feat(AdminFormsRoutes): add celebrate validtn for stream query params * build: update tsconfig.build to allow inconsistent casing due to transpiling code, some packages with lowercased type files will encounter some errors like: TS1261: Already included file name 'path/to/node_modules/@types/JSONStream/index.d.ts' differs from file name 'path/to/node_modules/@types/jsonstream/index.d.ts' only in casing. * test(EncryptSubSvc): add tests for getSubmissionCursor * fix: use local copy of jsonstream types * test(EncryptSubModel): add tests for getSubmissionCursorByFormId * ref: use StatusCodes enums instead of hardcoded numbers * feat: remove `end` event handler in stream the close handler should be enough to handle everything. From testing, the end event is not called anyways * ref(AdminFormsRoutes): extract out YYYYMMDD regex into variable * fix(AdminFormsRoutes): use Joi.object.and instead of object.with `with` allows for a query with only `endDate` since only `startDate` is required, which is wrong * ref(EncryptSubSvc): add transformAttachmentMetaStream function this is a refactor of the function recently added in #555 * feat(EncryptSubCtl): insert transform stream into download pipeline * feat: remove unused stream responses handler * feat(EncryptSubSvc): add logging to error also use for of loop for correct callback return * feat(EncryptSubCtl): add error handler for attachment pipe errors * test(EncryptSubSvc): add tests for transformAttachmentMetaStream * chore: trigger travis rebuild
Co-authored-by: Yuanruo Liang <yuanruo@open.gov.sg>
chore: merge release 4.45.1 hotfix back to develop
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.10.10 to 5.10.14. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.10.10...5.10.14) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tshuli
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.