Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(btn): use different growthbook api #7299

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 30, 2024

Problem

Used incorrect feature toggle endpoint.

useIsFeatureEnabled is our BE Feature flag service, while useFeatureValue is our growthbook feature toggle.

Solution

Switch to use useFeatureValue.

Breaking Changes

  • No - this PR is backwards compatible

@KenLSM KenLSM merged commit 435f915 into develop Apr 30, 2024
30 checks passed
@KenLSM KenLSM deleted the fix/growthbook-twilio branch April 30, 2024 04:31
@KenLSM
Copy link
Contributor Author

KenLSM commented Apr 30, 2024

Bypassed release requirements -- small change + urgency

KenLSM added a commit that referenced this pull request Apr 30, 2024
* fix(deps): bump zod from 3.23.0 to 3.23.4 in /shared (#7283)

Bumps [zod](https://github.com/colinhacks/zod) from 3.23.0 to 3.23.4.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](colinhacks/zod@v3.23.0...v3.23.4)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: reduce output, check gh login auth status only if not logged in (#7282)

* fix(deps): bump type-fest from 4.16.0 to 4.17.0 in /shared (#7287)

Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.16.0 to 4.17.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.16.0...v4.17.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: add localhost domain into cors, used by attachment uploads (#7280)

* feat(payments): add min global payment limit override (#7291)

* add flag to allow global min override in form

* allow fe variable fields to pass fe validators

* allow respondent variable payment flow to respect global min override value

* remove check min value check on respondent payment submission

* fix: add missing default variable

* test: add test cases for global limit

* feat(btn): phase 2 - add growthbook toggle to control adding twilio creds (#7290)

feat: add growthbook toggle to control adding twilio creds

* fix: update chromium version (#7294)

update chromium version

* fix(deps): bump type-fest from 4.17.0 to 4.18.0 in /shared (#7297)

Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.17.0 to 4.18.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.17.0...v4.18.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(payments): allow 0 cents (#7298)

fix: allow 0 cents

* fix(btn): use different growthbook api (#7299)

use different growthbook api

* chore: bump version to v6.118.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant