feat(btn): phase 2 - add growthbook toggle to control adding twilio creds #7290
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianwzq
approved these changes
Apr 29, 2024
KenLSM
added a commit
that referenced
this pull request
Apr 30, 2024
* fix(deps): bump zod from 3.23.0 to 3.23.4 in /shared (#7283) Bumps [zod](https://github.com/colinhacks/zod) from 3.23.0 to 3.23.4. - [Release notes](https://github.com/colinhacks/zod/releases) - [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md) - [Commits](colinhacks/zod@v3.23.0...v3.23.4) --- updated-dependencies: - dependency-name: zod dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: reduce output, check gh login auth status only if not logged in (#7282) * fix(deps): bump type-fest from 4.16.0 to 4.17.0 in /shared (#7287) Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.16.0 to 4.17.0. - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v4.16.0...v4.17.0) --- updated-dependencies: - dependency-name: type-fest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: add localhost domain into cors, used by attachment uploads (#7280) * feat(payments): add min global payment limit override (#7291) * add flag to allow global min override in form * allow fe variable fields to pass fe validators * allow respondent variable payment flow to respect global min override value * remove check min value check on respondent payment submission * fix: add missing default variable * test: add test cases for global limit * feat(btn): phase 2 - add growthbook toggle to control adding twilio creds (#7290) feat: add growthbook toggle to control adding twilio creds * fix: update chromium version (#7294) update chromium version * fix(deps): bump type-fest from 4.17.0 to 4.18.0 in /shared (#7297) Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.17.0 to 4.18.0. - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v4.17.0...v4.18.0) --- updated-dependencies: - dependency-name: type-fest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(payments): allow 0 cents (#7298) fix: allow 0 cents * fix(btn): use different growthbook api (#7299) use different growthbook api * chore: bump version to v6.118.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes frm-1718
Solution
Add growthbook toggle to toggle between enabling and disabling adding of Twilio Credentials on the Frontend.
Backend is not disabled as we will be:
Breaking Changes
Before & After Screenshots
Tests
Regression
Feature toggle is off, user should still see
will be, and able to add twilio credentialswill be disabled from 30 AprilNew feature test
stagingenv from growthbookwill be disabled from 30 AprilDeploy Notes
Ensure that
adding-twilio-disabledis added on growthbook (withvalue: True, but not toggled onproduction) . It should be disabled before April 30 or enabled if it is after April 30.New environment variables:
adding-twilio-disabled: on growth book to control text message and button.