Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(btn): frm 1717 mop flow to postman #7342

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented May 23, 2024

Problem

Closes FRM-1717

Solution

Migration of our SMS service from Twilio to Postman. We will want to remove Twilio completely and utilize specific Postman campaign IDs that's clearly segregated by (1) MOP and (2) INTERNAL at the SmsService level. This switches our SMS decisions to be determined by the targetted demographics[1] as opposed to sending an SMS out from the FormSG.

A new Service, PostmanSmsService, is created to allow us to control the roll outs before enabling it for all admins.

[1] This is necessary as we have a WOG mandate to ensure that ALL SMSes to MOPs must be from Postman.

#7343 implements the INTERNAL flow of this new SMS service.

Breaking Changes

  • No - this PR is backwards compatible

Tests

Deploy Notes

New environment variables:

  • POSTMAN_MOP_CAMPAIGN_ID
  • POSTMAN_MOP_CAMPAIGN_API_KEY
  • POSTMAN_BASE_URL

Copy link

linear bot commented May 23, 2024

@KenLSM KenLSM force-pushed the feat/frm-1717-mop-flow-to-postman branch from 6f9ab31 to a89a764 Compare May 23, 2024 15:39
@mergify mergify bot mentioned this pull request May 23, 2024
11 tasks
@KenLSM KenLSM requested a review from sebastianwzq June 3, 2024 03:56
@KenLSM KenLSM force-pushed the feat/frm-1717-mop-flow-to-postman branch from a9a581c to 193a1eb Compare June 17, 2024 16:38
Copy link
Contributor Author

KenLSM commented Jun 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @KenLSM and the rest of your teammates on Graphite Graphite

@KenLSM KenLSM requested a review from sebastianwzq June 17, 2024 16:52
@KenLSM KenLSM force-pushed the feat/frm-1717-mop-flow-to-postman branch from 61918a0 to 753925a Compare June 18, 2024 10:53
@KenLSM KenLSM merged commit 65cb0d4 into develop Jun 20, 2024
21 of 22 checks passed
@KenLSM KenLSM deleted the feat/frm-1717-mop-flow-to-postman branch June 20, 2024 06:39
@KenLSM KenLSM mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants