-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(btn): frm 1717 mop flow to postman #7342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
force-pushed
the
feat/frm-1717-mop-flow-to-postman
branch
from
May 23, 2024 15:39
6f9ab31
to
a89a764
Compare
11 tasks
KenLSM
force-pushed
the
feat/frm-1717-mop-flow-to-postman
branch
from
June 17, 2024 16:38
a9a581c
to
193a1eb
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sebastianwzq
approved these changes
Jun 18, 2024
KenLSM
force-pushed
the
feat/frm-1717-mop-flow-to-postman
branch
from
June 18, 2024 10:53
61918a0
to
753925a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes FRM-1717
Solution
Migration of our SMS service from Twilio to Postman. We will want to remove
Twilio
completely and utilize specific Postman campaign IDs that's clearly segregated by (1)MOP
and (2)INTERNAL
at the SmsService level. This switches our SMS decisions to be determined by the targetted demographics[1] as opposed to sending an SMS out from the FormSG.A new Service,
PostmanSmsService
, is created to allow us to control the roll outs before enabling it for all admins.[1] This is necessary as we have a WOG mandate to ensure that ALL SMSes to MOPs must be from Postman.
#7343 implements the
INTERNAL
flow of this new SMS service.Breaking Changes
Tests
Deploy Notes
New environment variables:
POSTMAN_MOP_CAMPAIGN_ID
POSTMAN_MOP_CAMPAIGN_API_KEY
POSTMAN_BASE_URL