feat(btn): frm 1723 internal flow postman #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KenLSM
changed the title
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
7daf1d7
to
6a68b77
Compare
KenLSM
force-pushed
the
feat/frm-1717-mop-flow-to-postman
branch
from
a9a581c
to
193a1eb
Compare
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
e7a4a5b
to
a86de0a
Compare
KenLSM
force-pushed
the
feat/frm-1717-mop-flow-to-postman
branch
from
61918a0
to
753925a
Compare
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
3b9b4e1
to
a805f0b
Compare
src/app/modules/verification/__tests__/verification.service.spec.ts
Outdated
Show resolved
Hide resolved
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
1dbc994
to
d567ca4
Compare
sebastianwzq
approved these changes
Jun 25, 2024
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
d567ca4
to
bfdf027
Compare
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
bfdf027
to
179ee8a
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
179ee8a
to
dcb7b4b
Compare
KenLSM
force-pushed
the
feat/frm-1723-internal-flow-postman
branch
from
dcb7b4b
to
3eb8211
Compare
g-tejas
pushed a commit
that referenced
this pull request
Jul 18, 2024
* add postman sms service * feat: add user betaflag for postman sms * add sendBouncedSubmissionSms * test: add sendBouncedSubmissionSms cases * add sendFormDeactivatedSms * add sendAdminContactOtp * add package-lock * remove non-mop sms services, point sms.errors to postman-sms.errors * migrate non-mop smses to use postman sms service * update tests to remove migrated functions * fix incorrect api key reference * fix form.admin not populated before passing into flag field * update test cases for bounce, sms service * update test cases for bounce service * update test cases for user controller * update sms error import path * refactor: rename mop sms to use internal api convention, fix typo on logmeta.action * chore: fix build failures due to merge conflicts * chore: remove redundant logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes FRM-1723
Solution
Migration of our SMS service from Twilio to Postman. We will want to remove
Twiliocompletely and utilize specific Postman campaign IDs that's clearly segregated by (1)MOPand (2)INTERNALat the SmsService level. This switches our SMS decisions to be determined by the targetted demographics[1] as opposed to sending an SMS out from the FormSG.A new Service,
PostmanSmsService, is created to allow us to control the roll outs before enabling it for all admins.[1] This is necessary as we have a WOG mandate to ensure that ALL SMSes to MOPs must be from Postman.
#7342 implements the
MOPflow of this new SMS service.Breaking Changes
Tests
Deploy Notes
sendAdminContactOtp: Admins verifying admin contact OTP should receive SMS OTP thru PostmansendBouncedSubmissionSms: Admins with email submissions bounced should receive SMS notification thru PostmanNew environment variables:
POSTMAN_INTERNAL_CAMPAIGN_IDPOSTMAN_INTERNAL_CAMPAIGN_API_KEY