Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serial] Allow custom baudrate and add option 2400 #13265

Merged
merged 1 commit into from
Aug 15, 2022
Merged

[serial] Allow custom baudrate and add option 2400 #13265

merged 1 commit into from
Aug 15, 2022

Conversation

lolodomo
Copy link
Contributor

Fix #13131

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[serial] Allow custom baudrate and add option 2400
c0b0a35 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Aug 15, 2022
@jlaur
Copy link
Contributor

jlaur commented Aug 15, 2022 •
edited
Loading

@lolodomo - broken in 3.3 as consequence of openhab/openhab-core#2720?

@lolodomo
Copy link
Contributor Author

This PR adds the ability to use 2400 or any custom baudrate.
No link with core PR.

@jlaur
Copy link
Contributor

jlaur commented Aug 15, 2022

@lolodomo - yes, was just looking for confirmation that this was a regression caused by mentioned PR in core. :)

jlaur
jlaur approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 8e8eb05 into openhab:main Aug 15, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 15, 2022
@lolodomo
Copy link
Contributor Author

In fact, the issue is mentioning 2 issues, the one with decimal value which is a core problem, and the one I am fixing with this PR.

@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on and removed enhancement An enhancement or new feature for an existing add-on labels Aug 15, 2022
@lolodomo lolodomo deleted the serial_baudrate branch August 15, 2022 15:32
@jlaur
Copy link
Contributor

jlaur commented Aug 15, 2022 •
edited
Loading

@lolodomo - okay, I'm assuming this one was indeed a regression in 3.3 caused by a change in core, so I have switched to "Bug" as label. If you disagree, please feel free to change it back.

MikeJMajor
MikeJMajor requested changes Aug 15, 2022
View reviewed changes
bundles/org.openhab.binding.serial/src/main/resources/OH-INF/thing/thing-types.xml
@@ -26,8 +26,10 @@
<advanced>true</advanced>
<label>Baud Rate</label>
<description>Set the baud rate</description>
<limitToOptions>false</limitToOptions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried adding this it stops the UI displaying the options and just presents a box to type in any number. What do you see?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, apparently in that case, Main UI does not show the options. But at least, you can enter any baudrate.

marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Aug 18, 2022
@lolodomo @marcelGoerentz
[serial] Allow custom baudrate and add option 2400 (openhab#13265)
2ee3f34 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@lolodomo @leifbladt
[serial] Allow custom baudrate and add option 2400 (openhab#13265)
18e5b55 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lolodomo @andan67
[serial] Allow custom baudrate and add option 2400 (openhab#13265)
0d15211 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lolodomo @andrasU
[serial] Allow custom baudrate and add option 2400 (openhab#13265)
4872f04 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@lolodomo @psmedley
[serial] Allow custom baudrate and add option 2400 (openhab#13265)
60b80c1 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lolodomo @nemerdaud
[serial] Allow custom baudrate and add option 2400 (openhab#13265)
e13398b 
Fix openhab#13131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeJMajor MikeJMajor MikeJMajor requested changes

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

[serial] Support custom baudrates
3 participants
@lolodomo @jlaur @MikeJMajor