Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent internal server error on invalid link requests on REST API #2179

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

kaikreuzer
Copy link
Member

This fixes the HTTP 500 error that I reported in openhab/openhab-webui#878 and also makes sure that such errors turn up in the log file and are no longer swallowed.

Signed-off-by: Kai Kreuzer kai@openhab.org

@kaikreuzer kaikreuzer requested a review from a team February 5, 2021 11:53
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Feb 5, 2021
@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Feb 5, 2021
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 3.1 milestone Feb 6, 2021
@cweitkamp cweitkamp merged commit 87211d2 into openhab:main Feb 6, 2021
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Feb 6, 2021
cweitkamp pushed a commit that referenced this pull request Feb 6, 2021
@kaikreuzer kaikreuzer deleted the restlink branch February 6, 2021 11:56
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
… API (openhab#2179)

Closes openhab/openhab-webui#878

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 87211d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch REST/SSE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants