Prevent errors in log when client closes the HTTP connection #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
commented
Dec 29, 2021
| // we catch this exception to avoid confusion errors in the log file, since this is not any error situation | ||
| // see https://github.com/openhab/openhab-distro/issues/1188 | ||
| logger.debug("Failed writing HTTP response, since other side closed the connection"); | ||
| // Returning null results in a Response.Status.NO_CONTENT response. |
There was a problem hiding this comment.
There was a problem hiding this comment.
Returning null sounds just fine. In any case, the client won't receive what we return at all and null seems to best indicate that there's really nothing to return from our side.
cweitkamp
commented
Dec 29, 2021
| // see https://github.com/openhab/openhab-distro/issues/1188 | ||
| logger.debug("Failed writing HTTP response, since other side closed the connection"); | ||
| // Returning null results in a Response.Status.NO_CONTENT response. | ||
| return null; |
There was a problem hiding this comment.
Another solution:
Suggested change
| return null; | |
| return Response.noContent().build(); |
Or:
Suggested change
| return null; | |
| return Response.serverError().build(); |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
bugfix-eofexception
branch
from
13c5f07
to
df61269
Compare
kaikreuzer
approved these changes
Dec 30, 2021
| // we catch this exception to avoid confusion errors in the log file, since this is not any error situation | ||
| // see https://github.com/openhab/openhab-distro/issues/1188 | ||
| logger.debug("Failed writing HTTP response, since other side closed the connection"); | ||
| // Returning null results in a Response.Status.NO_CONTENT response. |
There was a problem hiding this comment.
Returning null sounds just fine. In any case, the client won't receive what we return at all and null seems to best indicate that there's really nothing to return from our side.
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openhab/openhab-distro#1188 (comment) and #2049.
@openhab/core-maintainers Please tell me your opinion.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de