Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE of AddonServices during startup #2678

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Fix NPE of AddonServices during startup #2678

merged 2 commits into from
Jan 10, 2022

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer kai@openhab.org

@kaikreuzer
Fix NPE of JSONAddonService during startup
1267d2c 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Jan 10, 2022
@kaikreuzer kaikreuzer requested a review from a team January 10, 2022 06:40
@J-N-K
Copy link
Member

J-N-K commented Jan 10, 2022

This is already part of #2607.

@kaikreuzer
Copy link
Member Author

But #2607 seems to be much bigger and do a lot more.
I prefer small PRs that can be merged quickly for such bugs.

@J-N-K
Copy link
Member

J-N-K commented Jan 10, 2022

The CommunityMarketplaceAddonService has the same issue.

@cweitkamp
Copy link
Contributor

Looks good so far. Thanks.

We have to fix this in the CommunityMarketplaceAddonService too.

openhab-core/bundles/org.openhab.core.addon.marketplace/src/main/java/org/openhab/core/addon/marketplace/internal/community/CommunityMarketplaceAddonService.java

Line 482 in 0a778df

return (boolean) Objects.requireNonNullElse(configuration.getProperties().get("remote"), true);

@kaikreuzer
Add same fix for CommunityMarketplaceAddonService
1675d24 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

Ok, I have added it for CommunityMarketplaceAddonService, too.

@kaikreuzer kaikreuzer changed the title Fix NPE of JSONAddonService during startup Fix NPE of AddonServices during startup Jan 10, 2022
cweitkamp
cweitkamp approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit a8126bc into openhab:main Jan 10, 2022
@cweitkamp cweitkamp added this to the 3.3 milestone Jan 10, 2022
@wborn wborn mentioned this pull request Jan 10, 2022
Closed
@wborn wborn linked an issue Jan 10, 2022 that may be closed by this pull request
marketplace binding cannot be loaded #2673
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@kaikreuzer @splatch
Fix NPE of AddonServices during startup (openhab#2678)
e28a8c8 
* Fix NPE of JSONAddonService during startup
* Add same fix for CommunityMarketplaceAddonService

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: a8126bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

marketplace binding cannot be loaded
3 participants
@kaikreuzer @J-N-K @cweitkamp