Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose three classes used as bindings in JSR-223 rules as interfaces #2723

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Expose three classes used as bindings in JSR-223 rules as interfaces #2723

merged 3 commits into from
Feb 13, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 1, 2022

Fixes #2438

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

@J-N-K
expose three classes used as bidnings in JSR-223 rules as interfaces
7a1a958 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K requested a review from a team as a code owner February 1, 2022 16:33
@J-N-K
Copy link
Member Author

J-N-K commented Feb 1, 2022

Build failure does not occur in local build.

@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label Feb 2, 2022
wborn
wborn reviewed Feb 12, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to annotate all the new interfaces with @NonNullByDefault?

@J-N-K
add null annotations to ScriptBusEvent
109df1e 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
null annotations for ScriptThingActions
7c9f0ea 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Feb 12, 2022

Done. Also added additional null-checks.

wborn
wborn approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit 9a9217e into openhab:main Feb 13, 2022
@wborn wborn changed the title expose three classes used as bindings in JSR-223 rules as interfaces Expose three classes used as bindings in JSR-223 rules as interfaces Feb 13, 2022
@wborn wborn added this to the 3.3 milestone Feb 13, 2022
@J-N-K J-N-K deleted the expose-rulesupport branch February 13, 2022 09:50
@jimtng jimtng mentioned this pull request Feb 20, 2022
Merged
@J-N-K J-N-K mentioned this pull request Nov 25, 2022
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
Expose three classes used as bindings in JSR-223 rules as interfaces (o…
c7cc73e 
…penhab#2723)

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 9a9217e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[automation] Some classes are internal but exposed "accidentally"
3 participants
@J-N-K @wborn @cweitkamp