Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Imperial Pressure unit psi #2758

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Add new Imperial Pressure unit psi #2758

merged 1 commit into from
Feb 13, 2022

Conversation

jamesmelville
Copy link
Contributor

@jamesmelville
Add psi units
46fcf5e 
Signed-off-by: James Melville <jamesmelville@gmail.com>
@jamesmelville jamesmelville requested a review from a team as a code owner February 12, 2022 21:52
wborn
wborn approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the unit!

@wborn wborn merged commit b594d0a into openhab:main Feb 13, 2022
@wborn wborn added the enhancement An enhancement or new feature of the Core label Feb 13, 2022
@wborn wborn added this to the 3.3 milestone Feb 13, 2022
@wborn
Copy link
Member

wborn commented Feb 13, 2022 •
edited
Loading

Can you also create a PR to add it to the list of units in the docs @jamesmelville?

See:

@jamesmelville jamesmelville mentioned this pull request Feb 13, 2022
Merged
@cweitkamp cweitkamp added the UoM Units of Measurement label Feb 14, 2022
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@jamesmelville @splatch
Add new Imperial Pressure unit psi (openhab#2758)
8550c06 
Signed-off-by: James Melville <jamesmelville@gmail.com>
GitOrigin-RevId: b594d0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core UoM Units of Measurement
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesmelville @wborn @cweitkamp