Do not allow empty last segment in UID #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segments are not allowed to be empty. Also adds tests for UID construction. Signed-off-by: Jan N. Klug <github@klug.nrw>
kaikreuzer
changed the title
This was referenced Apr 17, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Fix empty segment in UID Segments are not allowed to be empty. Also adds tests for UID construction. Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 4fbd4c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2900
The last segment is not allowed to be empty. Also adds tests for UID construction.
Originally I thought (and still think) that empty segments make no sense at any position. But at least for
ThingUIDthere is a test that ensures that a missing thing-type is considered a valid UID.Signed-off-by: Jan N. Klug github@klug.nrw