Fix item name checking in ItemUtil #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
You also reject _ as first character. |
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
My question was rather: what will happen if users defined items starting with a number ? |
|
Yes, a warning will be logged when a provider tries to add that to the item registry. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/update-3-1-3-4-loss-of-sematic-model/142323/3 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Fix item name checking in ItemUtil Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 792b751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2243
Since numbers as first character of the item name cause issues and the documentation already states that they are not allowed, the validity check is adjusted to reflect the correct policy.
Signed-off-by: Jan N. Klug github@klug.nrw