Fix resource leaks in AudioServlet #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Code looks good to me. |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: d523275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
Add closing of streams on deactivation and add tests to ensure that all streams are closed after they are expired or retrieved.
There might be still one possible resource leak: a one-time stream that is served but never retrieved will stay in the map forever. But since that is exactly the wanted behavior for streams without timeout, there is nothing we can do about it. Those streams are only closed if the servlet is deactivated.
Signed-off-by: Jan N. Klug github@klug.nrw