Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console extension output to wrong console #2961

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix console extension output to wrong console #2961

merged 1 commit into from
May 16, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 13, 2022

Fixes #1545

The PrintStream used for printing should not be System.out but the PrintStream associated with the Session of the karaf shell.

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K
Fix console extension output to wrong console
fac2546 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label May 13, 2022
@J-N-K J-N-K requested a review from a team as a code owner May 13, 2022 22:32
@robnielsen robnielsen mentioned this pull request May 14, 2022
Merged
kaikreuzer
kaikreuzer approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

@kaikreuzer kaikreuzer added this to the 3.3 milestone May 16, 2022
@kaikreuzer kaikreuzer merged commit 9100473 into openhab:main May 16, 2022
@J-N-K J-N-K deleted the bug-osgiconsole branch May 16, 2022 20:35
@wborn wborn mentioned this pull request Jun 9, 2022
Closed
@J-N-K J-N-K mentioned this pull request Jun 22, 2022
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
Fix console extension output to wrong console (openhab#2961)
5258c42 
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 9100473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

OSGiConsole outputs to where thread was started, not in current console window
2 participants
@J-N-K @kaikreuzer