Allow generation of default translations for automation modules #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-N-K
added
enhancement
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
feature-i18naddjsontranslations
branch
from
aca4b40
to
718979a
Compare
|
@cweitkamp I'd think you might be the best expert to review this PR, in case you find time. |
cweitkamp
reviewed
May 29, 2022
...18n-plugin/src/main/java/org/openhab/core/tools/i18n/plugin/JsonToTranslationsConverter.java
Outdated
Show resolved
Hide resolved
...18n-plugin/src/main/java/org/openhab/core/tools/i18n/plugin/JsonToTranslationsConverter.java
Outdated
Show resolved
Hide resolved
...18n-plugin/src/main/java/org/openhab/core/tools/i18n/plugin/JsonToTranslationsConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Done. |
This was referenced Jul 9, 2022
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jul 9, 2022
These were generated using openhab#2966. Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
pushed a commit
that referenced
this pull request
Jul 10, 2022
These were generated using #2966. Signed-off-by: Wouter Born <github@maindrain.net>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
openhab#2966) * Allow generation of default translations for automation modules Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: d6c269d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2839
Signed-off-by: Jan N. Klug github@klug.nrw