Fix ConcurrentModificationException in WatchQueueReader #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-3-milestone-discussion/132715/221 |
|
I believe it's not very likely, considering that we have not seen reports about that in the past (and the code didn't change for some time). But changing |
J-N-K
approved these changes
Jun 26, 2022
|
@J-N-K - should milestone be set to 3.3? |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: 2cf875f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://community.openhab.org/t/openhab-3-3-milestone-discussion/132715/220
@openhab/core-maintainers: I don't know how likely this race condition is to happen - please decide whether you consider it critical and merge it for 3.3 or leave it for later.
Signed-off-by: Kai Kreuzer kai@openhab.org