Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimeTrigger] Adjust to system timezone #3060

Merged
merged 3 commits into from
Aug 12, 2022
Merged

[DateTimeTrigger] Adjust to system timezone #3060

merged 3 commits into from
Aug 12, 2022

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 10, 2022 •
edited
Loading

@jimtng
[DateTimeTrigger] Adjust to system timezone
ef10884 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner August 10, 2022 11:29
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Aug 10, 2022
J-N-K
J-N-K reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Can you add a test that ensures this will not break again (i.e. a test that checks that the cronExpression is properly handled in both cases: the TZ of the value is the same as system TZ and different from system TZ)?

@jimtng
[DateTimeTrigger] Add tests for DateTimeTriggerHandler
9072079 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Aug 11, 2022

I've added a test

@J-N-K
Update bundles/org.openhab.core.automation/src/test/java/org/openhab/…
1164846 
…core/automation/internal/module/handler/DateTimeTriggerHandlerTest.java
@J-N-K J-N-K merged commit 8f745b0 into openhab:main Aug 12, 2022
@J-N-K J-N-K added this to the 3.4 milestone Aug 12, 2022
@jimtng jimtng deleted the datetimetrigger-zone branch August 13, 2022 01:13
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@jimtng @splatch
Fix timezone handling in DateTimeTrigger (openhab#3060)
82cbba3 
* [DateTimeTrigger] Adjust to system timeline
* [DateTimeTrigger] Add tests for DateTimeTriggerHandler

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
GitOrigin-RevId: 8f745b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

DateTimeTrigger not taking timezones into account
2 participants
@jimtng @J-N-K