[tls] Rethrow 'IOException' instead of swallowing it #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
cweitkamp
changed the title
J-N-K
reviewed
Sep 10, 2022
| */ | ||
| public PEMTrustManager(String pemCert) throws CertificateException { | ||
| if (!pemCert.isBlank() && pemCert.startsWith(BEGIN_CERT)) { | ||
| try (InputStream certInputStream = new ByteArrayInputStream(pemCert.getBytes(StandardCharsets.UTF_8))) { | ||
| trustedCert = (X509Certificate) CertificateFactory.getInstance("X.509") | ||
| .generateCertificate(certInputStream); | ||
| } catch (IOException e) { | ||
| throw new CertificateException(e); | ||
| LoggerFactory.getLogger(PEMTrustManager.class).debug("An IOException occurred: {}", e.getMessage()); |
There was a problem hiding this comment.
Why is the logger not an instance field? Otherwise LGTM
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
J-N-K
approved these changes
Sep 10, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Rethrow IOException instead of swollowing it Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: f33492d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOExceptioninstead of swallowing itIn case of unreachable servers there is an
IOExceptionleading to an error message in the log file. This case can be handled even better when rethrowing the thrown exception which allows the calling instance to react to server side errors.https://community.openhab.org/t/vizio-tv-binding/138367/12
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de