Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EventLogger performance #3523

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Improve EventLogger performance #3523

merged 2 commits into from
Apr 7, 2023

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Apr 4, 2023

Just a very minor change, but since this gets called a lot, might be worth it.

  • Cleaner code
  • Avoid doing string concat every time

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner April 4, 2023 14:47
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 7, 2023
@J-N-K J-N-K merged commit a39beed into openhab:main Apr 7, 2023
@J-N-K J-N-K changed the title EventLogger minor refactor Refactor EventLogger Apr 7, 2023
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Apr 7, 2023
@J-N-K J-N-K changed the title Refactor EventLogger Improve EventLogger performance Apr 7, 2023
@J-N-K J-N-K added this to the 4.0 milestone Apr 7, 2023
@jimtng jimtng deleted the event-logger branch April 9, 2023 14:46
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* EventLogger minor refactor

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>

* Fix null check

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>

---------

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
GitOrigin-RevId: a39beed
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-migration-faq/148144/18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants