[rest] TokenResource: Set SameSite attribute for session id cookie #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cookie Fixes #4159. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
J-N-K
requested changes
Mar 27, 2024
...ab.core.io.rest.auth/src/main/java/org/openhab/core/io/rest/auth/internal/TokenResource.java
Outdated
Show resolved
Hide resolved
...ab.core.io.rest.auth/src/main/java/org/openhab/core/io/rest/auth/internal/TokenResource.java
Outdated
Show resolved
Hide resolved
Co-authored-by: J-N-K <github@klug.nrw> Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
Done 👍 |
J-N-K
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4159.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value.
Because our current implementation of
javax.ws.rs.core.NewCookie(which isjakarta.ws.rs/jakarta.ws.rs-api/2.1.6provided byorg.apache.aries.spec/org.apache.aries.javax.jax.rs-api/1.0.4) does not allow to set the SameSite attribute, we have to workaround that limitation by setting the cookie directly through a response header.Once our implementation is
jakarta.ws.rs/jakarta.ws.rs-api/3.1.0or newer, we can useNewCookieagain.Implementing the required changes to NewCookie on our own does not work, because the servlet also needs adustment.