-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SDDP service for addon discovery and thing discovery #4237
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Pinging @mherwege and @mlobstein for info.. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
...overy.sddp/src/test/java/org/openhab/core/config/discovery/sddp/test/SddpDiscoveryTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
...dp/src/test/java/org/openhab/core/config/discovery/addon/sddp/test/SddpAddonFinderTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Note to Reviewers: SDDP has a very low LAN footprint. In background (passive scan) mode it simply subscribes to, and listens on, the designated SDDP multicast address/port for UDP |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
...e.config.discovery.sddp/src/main/java/org/openhab/core/config/discovery/sddp/SddpDevice.java
Show resolved
Hide resolved
...e.config.discovery.sddp/src/main/java/org/openhab/core/config/discovery/sddp/SddpDevice.java
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
...e.config.discovery.sddp/src/main/java/org/openhab/core/config/discovery/sddp/SddpDevice.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Status Update
|
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@mherwege my latest commit is now working correctly :) -- please have a look at it; and I will look at yours too.
|
...y.addon.sddp/src/main/java/org/openhab/core/config/discovery/addon/sddp/SddpAddonFinder.java
Show resolved
Hide resolved
My changes did indeed make it pass feature verification, but it will not work. You do indeed need to set the SddpDiscoveryService and register the participant, which was still missing in my version. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@mlobstein I am currently running a full build of this PR together with your openhab/openhab-addons#16802 and openhab/openhab-addons#16794 to see if it all works as expected. I assume that you are doing the same thing? If so, then please provide feedback. Note that I don't own a physical Epson Projector so in my tests I am using a test app to simulate the projector. Therefore your own tests would ultimately be more definitive than mine. |
I just pushed a small fix to my branch. The SDDP discovery is working as expected. I also do not have a projector that supports SDDP. I am testing with my Pana UB-9000 by changing the strings in the DiscoveryParticipant. The device is discovered automatically and from an active scan. The discovered thing can be added successfully. |
@mlobstein just to confirm that the core finder service does discover an addon for my 'fake' Epson device, and the discovery service in your binding does indeed find the respective thing -- see below |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Note Java 17 CI build failed for some reason probably unrelated to this PR? |
@mherwege I would like to give you particular thanks for your help in general concerning OSGI component instantiation and referencing, and in specific concerning the respective karaf features construction. :) I also want to thank you for your work on OH WebUI concerning the addon finders (enablement UI, display UI), as well as the primary IP selector page. The workflow on new installs is now very smooth and intuitive. Many thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @andrewfg, and thank you all for this team effort!
Lets go for a try.
This PR has introduced JavaDoc warnings causing the build to fail. Can you fix them @andrewfg? See: https://ci.openhab.org/view/Documentation/job/openHAB-JavaDoc/779/console
|
How about changing the |
Resolves #4234
This PR provides an SDDP service for discovering equipment on the LAN. It has twofold application:
SddpDiscoveryParticipant
that allows discovering Things. It operates similarly to the MDNS and UPNP discovery services.Signed-off-by: Andrew Fiddian-Green software@whitebear.ch