Support offset in DateTimeTrigger #4271
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/subtracting-2-hours-from-datetime-item/156582/11 |
|
Don't forget to open an issue/PR on MainUI to add support to the UI. I'm excited to see this new feature. Thanks! |
IIRC Main UI is using the config description provided through REST, so no need to update it. |
...rc/main/java/org/openhab/core/automation/internal/module/handler/DateTimeTriggerHandler.java
Show resolved
Hide resolved
holgerfriedrich
added
rebuild
|
@holgerfriedrich thanks for reviewing and merging. Would you mind starting a core + distro build please? Waiting for it in order to run tests for openhab/openhab-jruby#278 |
|
@jimtng I don't think I have permission to do this. Let's ask @kaikreuzer, @wborn, @J-N-K to trigger a core build.... |
|
I have triggered a Core build! |
|
Thanks, @wborn! Will it automatically trigger a distro build upon a successful core build? |
|
No but I also just clicked that button. 🚀 |
|
Thanks! |
Refs openhab/openhab-core#4271. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Refs openhab/openhab-core#4271. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Closes #378. Refs openhab/openhab-core#4271. Whilst this changes the signature of the DateTimeTrigger, a special handling for the old signature is implemented to keep backward compatibility. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Resolve #4195
This should be merged before #4272 (Rules DSL support)