-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix startup of background discovery #4323
Conversation
Apply the same logic in AbstractThingHandlerDiscoveryService as in AbstractDiscoveryService to determine if background discovery should be enabled or disabled. Fix openhab/openhab-addons#17089 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@openhab/core-maintainers : this PR fixes a severe bug leading to background discovery in bindings being always disabled. |
But your fix enables it by default, while the default was disabled before. |
The default was enabled by default until you changed it when you introduced this new class (and great mechanism). Except if you checked and changed all bindings discovery (and just forgot freeboxos), we have to restore the original default. By the way, the two classes should be aligned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Apply the same logic in AbstractThingHandlerDiscoveryService as in AbstractDiscoveryService to determine if background discovery should be enabled or disabled. Fix openhab/openhab-addons#17089 Signed-off-by: Laurent Garnier <lg.hc@free.fr> (cherry picked from commit 0a5886c)
Apply the same logic in AbstractThingHandlerDiscoveryService as in AbstractDiscoveryService to determine if background discovery should be enabled or disabled.
Fix openhab/openhab-addons#17089
Signed-off-by: Laurent Garnier lg.hc@free.fr