Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix handling of new symmetric add operation #122

Merged

Conversation

michael-platzer
Copy link
Contributor

I'd like to apologize, when submitting PR #114 adding the new symmetric add operation ADDS, I overlooked three things:

  • the new operation of course needs to be added to the case statements that assign default values to the operands based on the operation in both fpnew_fma.sv and fpnew_fma_multi.sv
  • the multi FMA's addend exponent needs to be rebiased for the dst format (so far this was not necessary because the addend was already in dst format - however, for the ADDS operation it is not)
  • when extracting an FMA lane's local operands the operands_i[2] needs to be shifted using the correct format, which for the ADDS operation is the src format and not the dst format

This PR fixes these issues. Please excuse my sloppiness 🙈

@stmach stmach merged commit 81c53c5 into openhwgroup:develop May 23, 2024
1 check passed
@michael-platzer michael-platzer deleted the fix/multi-fma-symmetric-add branch May 26, 2024 08:30
michael-platzer added a commit to michael-platzer/cvfpu that referenced this pull request Aug 22, 2024
* 🐛 Add new ADDS operation to FMA case statements

* 🐛 Rebias multi FMA addend exponent to dst fmt

* 🐛 Extract multi FMA local op[2] with correct format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants