Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users page refactor #13

Merged
merged 12 commits into from
Jun 18, 2021
Merged

Users page refactor #13

merged 12 commits into from
Jun 18, 2021

Conversation

beygorghor
Copy link
Collaborator

@beygorghor beygorghor commented Jun 14, 2021

Screenshot 2021-06-14 at 21 15 18

Screenshot 2021-06-14 at 16 10 50

-This PR includes a multiple bug fixes on user picker

  • New user types and role picker (multi select)
  • New users list and detail page

⚠️ Maybe add locations fields to the detail page

Going along with this openimis/openimis-fe_js#20

@beygorghor beygorghor requested a review from edarchis June 14, 2021 19:35
@lgtm-com
Copy link

lgtm-com bot commented Jun 14, 2021

This pull request introduces 9 alerts when merging 87b9ffd into e7af28c - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class
  • 1 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

@beygorghor beygorghor marked this pull request as ready for review June 15, 2021 08:05
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 9 alerts when merging 703c97e into e7af28c - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class
  • 1 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

Various small issues when there was no interactive user but a claim admin or to a lesser degree officer.
The reducer was updated to remap the various objects to the same format as the Mutation, this makes the unified editing a lot simpler down the line.
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 10 alerts when merging cc4de23 into e7af28c - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
  • 1 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 10 alerts when merging 0e48caf into e7af28c - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
  • 1 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 10 alerts when merging 88a66e0 into e7af28c - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
  • 1 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2021

This pull request introduces 3 alerts when merging 863b2b5 into e7af28c - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update
  • 1 for Unused variable, import, function or class
  • 1 for Unused or undefined state property

@edarchis edarchis merged commit 9980534 into main Jun 18, 2021
@edarchis edarchis deleted the users branch July 5, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants