Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions are not closable #1

Closed
friedger opened this issue Jan 25, 2019 · 4 comments
Closed

Instructions are not closable #1

friedger opened this issue Jan 25, 2019 · 4 comments
Assignees
@widged
Labels
bug Something isn't working
Milestone
App Mining February

Comments

@friedger
Copy link
Member

No description provided.

@friedger friedger added the bug Something isn't working label Jan 25, 2019
@widged
Copy link
Collaborator

widged commented Jan 25, 2019

[X] button does not react to click

@friedger friedger added this to the App Mining February milestone Jan 28, 2019
@widged
Copy link
Collaborator

widged commented Jan 28, 2019 •
edited
Loading

Would you like anything to display on the screen when instructions are not visible? A button with show instructions or something of the like? Another option would be to offer to collapse/expand instead of removing it altogether.

widged referenced this issue in widged/oi-calendar Jan 28, 2019
@widged
#1 clicking on [x] now hides the instructions
32edcac
@widged widged self-assigned this Jan 28, 2019
@widged
Copy link
Collaborator

widged commented Jan 28, 2019

[resolved on https://github.com/widged/oi-calendar, pending pull request]

@friedger
Copy link
Member Author

It shouldn't be shown anything when closed

@widged widged mentioned this issue Jan 28, 2019
Merged
friedger added a commit that referenced this issue Jan 28, 2019
@friedger
Merge pull request #18 from widged/issues
73a6c7f 
Refactoring, dot files, Issue #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@widged widged

Labels
bug Something isn't working
Projects
None yet
Milestone
App Mining February
Development

No branches or pull requests
2 participants
@widged @friedger