Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for Calendars and Contacts #30

Closed
5 tasks done
friedger opened this issue Feb 1, 2019 · 6 comments
Closed
5 tasks done

Settings for Calendars and Contacts #30

friedger opened this issue Feb 1, 2019 · 6 comments
Assignees

Comments

@friedger
Copy link
Member

friedger commented Feb 1, 2019

Users should be able

  • to hide/show calendars (toggle active with checkbox, use inactive property)

  • to change color settings

  • to remove calendars with rubbish bin icon for each entry

  • to remove contacts with rubbish bin icon for each entry

  • the changes need to be persisted

@friedger friedger changed the title Settings for Calendars Settings for Calendars and Contacts Feb 4, 2019
@widged
Copy link
Collaborator

widged commented Feb 4, 2019

[ ] Settings should display as page instead of modal (which should probably be another issue)

@widged
Copy link
Collaborator

widged commented Feb 4, 2019

Proposed changes in functionality, as discussed today:
screen shot 2019-02-04 at 15 41 57

@widged
Copy link
Collaborator

widged commented Feb 4, 2019

[x] to hide/show calendars (toggle active) with checkbox

What attribute would you prefer to attach to the calendar items? Best is to have a value to indicate that the calendar is NOT active, as by default, if no attribute is specified, all calendars should be active. Possible options are inactive, disabled.

Note that code will need to be updated at least in the initializeCalendars to not include the events from calendars with an inactive/disabled attribute.

@widged
Copy link
Collaborator

widged commented Feb 4, 2019

[x] the changes needs to be persisted

Changes made within the settings panel environment trigger updates in the calendars list, which are persisted. However, it does not trigger any change in the "allEvents" that are displayed in the calendar. It might be a good idea to create another issue for that as this might require important changes in the data flow.

@widged
Copy link
Collaborator

widged commented Feb 4, 2019

[x] to remove calendars with rubbish bin icon for each entry

@widged
Copy link
Collaborator

widged commented Feb 4, 2019

[x] to remove contacts with rubbish bin icon for each entry

The contact list is empty with my login and new contacts cannot be added because "lookupContacts" is not implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants